Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Full-width layout #5007

Open
3 tasks done
deepspaceaxolotl opened this issue Apr 23, 2024 · 3 comments · May be fixed by #5294
Open
3 tasks done

[Feature Request]: Full-width layout #5007

deepspaceaxolotl opened this issue Apr 23, 2024 · 3 comments · May be fixed by #5294

Comments

@deepspaceaxolotl
Copy link

Guidelines

  • I have searched the issue tracker for open and closed issues that are similar to the feature request I want to file, without success.
  • I have searched the documentation for information that matches the description of the feature request I want to file, without success.
  • This issue contains only one feature request.

Problem Description

Spinning this off from #3918, the layout of a lot of pages, such as the subscriptions page, could be wider, as the current padding limits the number of videos that can be displayed in favour of empty space, particularly on small screens or at higher zoom levels.

Proposed Solution

Implement a setting for a full-width layout as per #4379, excluding the settings page which is fine as is and would be too busy otherwise.

Alternatives Considered

Allow for custom CSS styling? Much more complex to implement but would solve a lot of issues in advance, potentially.

Issue Labels

visual improvement

Additional Information

No response

@deepspaceaxolotl
Copy link
Author

As it currently stands, on smaller screens (in my case, 1080p at 125% zoom, making it effectively act like an 864p screen), it is not possible to both have a narrow enough window to see the video and playlist controls for a video without scrolling and to have a full grid of four columns on playlist, channel and subscriptions pages. Would love for any solution to allow for this, though that perhaps might require opening another issue about the location of the video and playlist control buttons (which are pushed down by both the likes count and the row the channel name is in, even if the former is turned off).

@alaestor
Copy link

Custom CSS would fix a few minor annoyances and people will probably come up with presets and themes similar to what the Stylus community does on browser.

I keep using F12 to tweak the video player's max-inline-size from 142.4vh to 168vh so that threatre mode wastes less space on my 4K monitor (since I don't like fullscreen but full window doesn't have a shortcut and hides the left sidebar). I'm not sure if there's a standard way of making persistent changes to an app's css, but regardless: it would be nice if I could just slap that in a textbox in the settings somewhere.

@pkrasicki
Copy link
Contributor

pkrasicki commented Oct 14, 2024

@alaestor

Custom CSS would fix a few minor annoyances and people will probably come up with presets and themes similar to what the Stylus community does on browser.

As I user I agree and I would love that, but as a developer I would be against adding such feature. UI should be intuitive and responsive by default, it shouldn't require extra fixes from users. If it does, then something is wrong. Stylus is needed to give us some control over other people's apps. But here we already have control, we can implement any UI changes we need. Maybe we just need more users to show interest in those changes, so that the dev team knows that they are needed.

I keep using F12 to tweak the video player's max-inline-size from 142.4vh to 168vh so that threatre mode wastes less space on my 4K monitor (since I don't like fullscreen but full window doesn't have a shortcut and hides the left sidebar). I'm not sure if there's a standard way of making persistent changes to an app's css, but regardless: it would be nice if I could just slap that in a textbox in the settings somewhere.

If you don't mind compiling FreeTube, here is my custom patch for 0.20.0 implemented almost entirely in CSS, it adds full width layout and my other custom changes. You can edit the SCSS file and easily add your own CSS to it. It's an old version (I haven't published a newer one), but it should work even in 0.21.x with some imperfections. The downside of my solution compared to yours is that it requires recompiling any time you make a change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To assign
Development

Successfully merging a pull request may close this issue.

4 participants