[BUGFIX] OutOfBounds fix when no lime_vorbis and a bit of refactoring
#4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apparently it goes out of bounds in all targets but for some reason Lime only does bound checking in HashLink. Even so, I'm confused why it doesn't throw an error in all of them. |
NotHyper-474
force-pushed
the
bugfix/hashlink-error
branch
2 times, most recently
from
d781ea4 to
2d348a4
Compare
NotHyper-474
force-pushed
the
bugfix/hashlink-error
branch
from
2d348a4 to
9f7d2d5
Compare
NotHyper-474
changed the title
OutOfBounds fix for no lime_vorbis and a bit of refactoring
NotHyper-474
changed the title
OutOfBounds fix for no lime_vorbis and a bit of refactoringOutOfBounds fix when no lime_vorbis and a bit of refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain songs wouldn't load on HashLink, turns out the
while (byteNum < oggRangeMax - oggRangeMin)loop was going out of bounds and causing an error, probably something to do with the fact it was not being converted into an Int? Anyway I made it check for the length of the array which is more reliableI've also removed the temp
numBytesvariable as it didn't make much sense to me (reusing it for efficiency perhaps?) and replaced the while loops with for ones, Haxe optimizes them as while loops behind the scenes anyway.And also just replaced
input.b.lengthwith justinput.lengthsince it didn't make any difference.