-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENCHANCEMENT] Additional Functionality for Playbars #4229
base: develop
Are you sure you want to change the base?
[ENCHANCEMENT] Additional Functionality for Playbars #4229
Conversation
Description: This PR adds switch logic for all playbars: Difficulty (playbarDifficulty) - Ctrl + Click -> open /close Difficulty Window BPM (playbarBPM) - Ctrl + Click -> open /close Metadata Window Note Snap (playbarNoteSnap) - Ctrl + Click -> open/close Note Window Song Remaining Time (playbarSongRemaining) (new toolbox function) - Click -> Offsets Window Also: Fixes FunkinCrew#4141 This repo will conflict with FunkinCrew#4143 since that PR fixes same bug.
deleting log comment
Hey, allow me to welcome you for making your first PR! Though usually, when you have an issue with an existing PR, you simply request changes on it, rather than making your own that makes the change, plus doing more. I'd make this PR only do the additional changes you've made, and make a PR on my branch for your changes, to mine or suggest changes to it. |
@Lasercar Oh ok, i could make it as addition to yours |
I guess I need to finish this branch and try to PR to yours? |
Yeah, but keep your additional changes - adding the same functionality to note snap and song remaining time, separate, as I had no part in doing that, ofc. |
Actually, no, I'll take the loss on this one, there's no way to separate the changes cleanly. Don't worry about doing that now, I've closed my PR. You can edit the descriptions of your PRs to remove the part about the conflict with mine. |
@Lasercar Oh damn, I guess it will be easier, But I actually used your solution with toolbar.selected, so you are made the contribution with it (Without it I wouldn't have a single idea). I just will change to "made on the basis of" your PR. Ok? |
Sure! I'm a little surprised that you learned off my code and figured out a better implementation. That's never happened to me before! |
Does this PR close any issues? If so, link them below.
Fixes #4141
Briefly describe the issue(s) fixed.
Enhancement:
This PR adds turning on/off logic for all playbars:
Difficulty (playbarDifficulty)
BPM (playbarBPM)
Note Snap (playbarNoteSnap)
Song Remaining Time (playbarSongRemaining) (new toolbox function)
Also:
( #132 funkin.assets ).
Include any relevant screenshots or videos.
2025-02-26.03-22-24.mp4