From 320394b9d1b6a5ad53760adf51aeccf1689e2f6a Mon Sep 17 00:00:00 2001 From: James Braza Date: Wed, 26 Feb 2025 10:54:07 -0800 Subject: [PATCH] Switched to packaging.version.parse over the (broken) tuple split --- trl/models/utils.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/trl/models/utils.py b/trl/models/utils.py index a5f484e151..8bc03e570b 100644 --- a/trl/models/utils.py +++ b/trl/models/utils.py @@ -19,6 +19,7 @@ from typing import TYPE_CHECKING, Literal, Optional, Union from accelerate.utils import is_deepspeed_available +from packaging import version from transformers import PreTrainedModel, PreTrainedTokenizer from .modeling_value_head import AutoModelForCausalLMWithValueHead, AutoModelForSeq2SeqLMWithValueHead @@ -174,7 +175,7 @@ def add_hooks(model: "DeepSpeedEngine") -> None: optimizer_offload = model.optimizer else: raise NotImplementedError(f"Didn't yet handle optimizer {model.optimizer}.") - if deepspeed.__version__.split(".") >= ("0", "16", "4"): + if version.parse(deepspeed.__version__) >= version.parse("0.16.4"): # Account for renaming in https://github.com/deepspeedai/DeepSpeed/pull/6847 optimizer_offload._register_deepspeed_module(optimizer_offload.module) else: