Issues with flang and FMS

[mathomp4]

In trying to build Baselibs with FMS, I've hit a few issues. A couple were reported upstream to FMS:

• CMake Bug with FMS (exposed by LLVM Flang) NOAA-GFDL/FMS#1739
• Compile time bug in mpp/include/mpp_chksum_int.fh with LLVM Flang NOAA-GFDL/FMS#1738

and @rem1776 fixed at least one of them (and maybe both? I lose track).

Still, if I hand fix both of those, I am still hitting something. The error is:

[ 85%] Building Fortran object CMakeFiles/fms_r8_f.dir/coupler/coupler_types.F90.o
error: Semantic errors in /discover/nobackup/projects/gmao/SIteam/Baselibs/TmpBaselibs/ESMA-Baselibs-8.18.0-FlangESMF/src/FMS/coupler/coupler_types.F90
/discover/nobackup/projects/gmao/SIteam/Baselibs/TmpBaselibs/ESMA-Baselibs-8.18.0-FlangESMF/src/FMS/coupler/coupler_types.F90:4119:38: error: No specific function of generic 'fms_io_register_restart_field' matches the actual arguments
          var%bc(n)%field(m)%id_rest = fms_io_register_restart_field(bc_rest_files(f),&
                                       ^
/discover/nobackup/projects/gmao/SIteam/Baselibs/TmpBaselibs/ESMA-Baselibs-8.18.0-FlangESMF/src/FMS/coupler/coupler_types.F90:4153:38: error: No specific function of generic 'fms_io_register_restart_field' matches the actual arguments
          var%bc(n)%field(m)%id_rest = fms_io_register_restart_field(rest_file,&
                                       ^
/discover/nobackup/projects/gmao/SIteam/Baselibs/TmpBaselibs/ESMA-Baselibs-8.18.0-FlangESMF/src/FMS/coupler/coupler_types.F90:4208:38: error: No specific function of generic 'fms_io_register_restart_field' matches the actual arguments
          var%bc(n)%field(m)%id_rest = fms_io_register_restart_field(bc_rest_files(f),&
                                       ^
/discover/nobackup/projects/gmao/SIteam/Baselibs/TmpBaselibs/ESMA-Baselibs-8.18.0-FlangESMF/src/FMS/coupler/coupler_types.F90:4240:38: error: No specific function of generic 'fms_io_register_restart_field' matches the actual arguments
          var%bc(n)%field(m)%id_rest = fms_io_register_restart_field(rest_file,&
                                       ^
gmake[4]: *** [CMakeFiles/fms_r8_f.dir/build.make:234: CMakeFiles/fms_r8_f.dir/coupler/coupler_types.F90.o] Error 1
gmake[4]: Leaving directory '/gpfsm/dnb05/projects/p50/Baselibs/TmpBaselibs/ESMA-Baselibs-8.18.0-FlangESMF/src/FMS/build'
gmake[3]: *** [CMakeFiles/Makefile2:231: CMakeFiles/fms_r8_f.dir/all] Error 2
gmake[3]: Leaving directory '/gpfsm/dnb05/projects/p50/Baselibs/TmpBaselibs/ESMA-Baselibs-8.18.0-FlangESMF/src/FMS/build'
gmake[2]: *** [Makefile:136: all] Error 2
gmake[2]: Leaving directory '/gpfsm/dnb05/projects/p50/Baselibs/TmpBaselibs/ESMA-Baselibs-8.18.0-FlangESMF/src/FMS/build'
make[1]: *** [GNUmakefile:1108: FMS.install] Error 2

From the name of the function in question, this is part of FMS1 IO and so is dead. Once we can move to FMS 2025, this is hopefully fixed.

But I'm making the issue now so I don't forget.