Context
On the release/MAPL-v3 branch we are preparing to flip use MAPL to import MAPL3 public entities. Components that have not yet been ported to MAPL3 will break at that point and will cause CI failures.
To protect CI we are temporarily deactivating non-ported components in CMake by commenting out their add_subdirectory / SUBCOMPONENTS entries. This makes it straightforward to re-activate each component as it is ported — just uncomment the relevant lines.
Components currently ported (remain active)
GEOSgwd_GridComp (GWD)FVdycoreCubed_GridComp (DynCore) — lives in its own repo, no change needed there
Changes required in this repo
GEOSagcm_GridComp/GEOSphysics_GridComp/CMakeLists.txt
- Comment out non-ported subdirs from
alldirs: GEOSchem_GridComp, GEOSmoist_GridComp, GEOSsurface_GridComp, GEOSturbulence_GridComp, GEOSradiation_GridComp
- Leave
GEOSgwd_GridComp active
- Replace the
esma_add_library / else block with a simple esma_add_subdirectories(${alldirs}) call (the top-level GEOS_PhysicsGridComp.F90 source USEs non-ported components, so we bypass it for now)
- Comment out the original
if/esma_add_library/else/esma_add_subdirectories/endif block with a note explaining how to restore it
GEOSagcm_GridComp/GEOSsuperdyn_GridComp/CMakeLists.txt
- Comment out non-ported subdirs from
alldirs: FVdycore_GridComp, GEOSdatmodyn_GridComp, ARIESg3_GridComp
- Leave
FVdycoreCubed_GridComp active
- Replace the conditional library block with a simple
esma_add_subdirectories(${alldirs}) (bypass GEOS_SuperdynGridComp.F90 which USEs non-ported components)
- Comment out the original block with a restore note
Feature branch
feature/deactivate-nonported-mapl3-components
Related issues
- GEOSchem_GridComp: (to be filed)
- GOCART: (to be filed)
Reverting
To re-activate a component as it is ported, simply uncomment its entry in alldirs and, once all components in a given CMakeLists.txt are restored, uncomment the esma_add_library block and remove the temporary esma_add_subdirectories bypass.
Context
On the
release/MAPL-v3branch we are preparing to flipuse MAPLto import MAPL3 public entities. Components that have not yet been ported to MAPL3 will break at that point and will cause CI failures.To protect CI we are temporarily deactivating non-ported components in CMake by commenting out their
add_subdirectory/SUBCOMPONENTSentries. This makes it straightforward to re-activate each component as it is ported — just uncomment the relevant lines.Components currently ported (remain active)
GEOSgwd_GridComp(GWD)FVdycoreCubed_GridComp(DynCore) — lives in its own repo, no change needed thereChanges required in this repo
GEOSagcm_GridComp/GEOSphysics_GridComp/CMakeLists.txtalldirs:GEOSchem_GridComp,GEOSmoist_GridComp,GEOSsurface_GridComp,GEOSturbulence_GridComp,GEOSradiation_GridCompGEOSgwd_GridCompactiveesma_add_library/elseblock with a simpleesma_add_subdirectories(${alldirs})call (the top-levelGEOS_PhysicsGridComp.F90sourceUSEs non-ported components, so we bypass it for now)if/esma_add_library/else/esma_add_subdirectories/endifblock with a note explaining how to restore itGEOSagcm_GridComp/GEOSsuperdyn_GridComp/CMakeLists.txtalldirs:FVdycore_GridComp,GEOSdatmodyn_GridComp,ARIESg3_GridCompFVdycoreCubed_GridCompactiveesma_add_subdirectories(${alldirs})(bypassGEOS_SuperdynGridComp.F90whichUSEs non-ported components)Feature branch
feature/deactivate-nonported-mapl3-componentsRelated issues
Reverting
To re-activate a component as it is ported, simply uncomment its entry in
alldirsand, once all components in a givenCMakeLists.txtare restored, uncomment theesma_add_libraryblock and remove the temporaryesma_add_subdirectoriesbypass.