Feature/wdboggs/#4660 add fill value acg3 (#4770)

* Add FILL_VALUE with alias to ACG3; unit tests

* Update CHANGELOG.md

---------

Co-authored-by: Tom Clune <thomas.l.clune@nasa.gov>

Author: darianboggs

Apps/MAPL_GridCompSpecs_ACGv3.py

@@ -92,11 +92,11 @@ def __str__(self):
 CONDITION = 'condition'
 DIMS = 'dims'
 EXPORT_NAME = 'export_name'
+FILL_VALUE = 'fill_value'
 INTENT_ARG = 'intent_arg'
 INTERNAL_NAME = 'internal_name'
 MANGLED = 'mangled'
 STANDARD_NAME_ARG = 'standard_name_arg'
-PRECISION = 'precision'
 RANK = 'rank'
 SHORT_NAME = 'short_name'
 SHORT_NAME_ARG = 'short_name_arg'
@@ -188,7 +188,6 @@ def get_options(args):
         SHORT_NAME: {MAPPING: MANGLED, FLAGS: MANDATORY},
         STATE_INTENT: {FLAGS: {MANDATORY}},
         STANDARD_NAME: {FLAGS: MANDATORY},
-        PRECISION: {},
         UNGRIDDED_DIMS: {MAPPING: ARRAY},
         VSTAGGER: {FLAGS: MANDATORY, MAPPING: {
              'C': 'VERTICAL_STAGGER_CENTER',
@@ -201,6 +200,7 @@ def get_options(args):
         CONDITION: {FLAGS: {STORE}},
         'dependencies': {MAPPING: STRINGVECTOR},
         EXPORT_NAME: {MAPPING: STRING},
+        FILL_VALUE: {},
         'itemtype': {},
         'orientation': {},
         'regrid_method': {},
@@ -228,12 +228,12 @@ def get_options(args):
         'long name': STANDARD_NAME,
         'long_name': STANDARD_NAME,
         'name': SHORT_NAME,
-        'prec': PRECISION,
         'vloc': VSTAGGER,
         'vlocation': VSTAGGER,
         'add2export': ADD_TO_EXPORT,
         'field dictionary': USE_FIELD_DICTIONARY,
-        'field_dictionary': USE_FIELD_DICTIONARY
+        'field_dictionary': USE_FIELD_DICTIONARY,
+        'fill': FILL_VALUE
     }
 
     # flow control

Apps/tests/acg3/acg3_unittests.py

@@ -167,6 +167,28 @@ def test_use_field_dictionary(self):
         values, missing_keys = digest_spec(s, options)
         assertFalse(use_field_dictionary in values, msg('use_field_dictionary should not be in values', s, values))
 
+    def test_fill_value(self):
+        # helpers
+        make_specs = lambda k, v: [{k: v, acg3.SHORT_NAME: 'FXX'}]
+        def get_value(key, field_value, final_key=None):
+            values, _ = acg3.get_values(make_specs(key, field_value), acg3.get_options({}))
+            return values[0][final_key if final_key else key]
+
+        # test for different types
+        for fv in '4.0 4.0D0 4 "4.0"'.split():
+            test = make_equal_test(self, fv)
+            actual = get_value(acg3.FILL_VALUE, fv)
+            msg = general_msg(variable='Field value', value=fv)
+            with self.subTest(test=test, actual=actual, msg=msg):
+                test(actual, msg)
+
+        # make sure results are the same for the key and the alias
+        fv = '4.0'
+        test = make_equal_test(self, get_value(acg3.FILL_VALUE, fv))
+        actual = get_value('fill', fv, final_key=acg3.FILL_VALUE)
+        msg = general_msg(variable='Field value', value=fv)
+        test(actual, msg)
+
 class TestHelpers(unittest.TestCase):
 
     def test_isiterable(self):

CHANGELOG.md

@@ -90,6 +90,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Add `use_field_dictionary` column to ACG3 with new unit tests.
 - Update cap restart file with current time at end of run.
 - Read/write repeatCount from/to cap restart file at beginning/end of run.
+- Added FILL_VALUE with alias to ACG3
 
 
 ### Changed