Clean up base/: delete dead code, migrate FileMetadataUtils to base3g, fix stale tests (refs #4884) (#4885)

* Delete TimeStringConversion; replace callers with ESMF_TimeSet/mapl_HConfigAsTimeInterval (refs #4884)

* Delete getrss.c, memuse.c, ServerManager.F90; move Python files to Apps/; remove obsolete OS guards (refs #4884)

* Delete MAPL_ESMFTimeVectorMod, MAPL_VerticalInterpMod, MAPL_VerticalMethods; remove dead imports (refs #4884)

* Remove vestigial MAPL.base dependency from MAPL.gridcomps (refs #4884)

* Move FileMetadataUtilities and FileMetadataUtilitiesVector from base/ to base3g/ (refs #4884)

* Replace MAPL.base with MAPL.base3g in GeomIO, vertical, ExtData3G, Regrid_Util.x; use mapl_base3g in MAPL2 (refs #4884)

* Migrate base/tests: move sort/DirPath to shared/tests, delete stale/deleted tests (refs #4884)

* Add HConfigAsTimeRange and string_to_esmf_time; fix valid_range/source_time parsing in ExtData3G (refs #4884)

- Add private string_to_esmf_time helper: robustly parses YYYY-MM-DD
  and YYYY-MM-DDThh:mm:ss without relying on ESMF_TimeSet(timeString=)
- Fix as_time/iter_as_time to use string_to_esmf_time (fixes date-only strings)
- Add HConfigAsTimeRange interface (as_timerange/iter_as_timerange): reads
  HConfig string, splits on '/' using scan(), returns ESMF_Time array of size 2
- Use scan() instead of index() intrinsic to avoid shadowing by dummy arg 'index'
- Export mapl_HConfigAsTimeRange from hconfig/API.F90
- ExtDataCollection: use mapl_HConfigAsTimeRange for valid_range key
- ExtDataSample: use mapl_HConfigAsTimeRange for source_time key
- Add unit tests for HConfigAsTime (with T, date-only) and HConfigAsTimeRange

* Fix Test_HConfigAs: split semicolon-separated @assertEqual onto separate lines (refs #4884)

pFUnit preprocessor does not support multiple @Assert macros on one line
separated by semicolons.

* Store ExtDataRule%start_time as ESMF_Time; parse via mapl_HConfigAsTime (refs #4884)

- Change ExtDataRule%start_time from character(:) to type(ESMF_Time), allocatable
- Parse 'starting' key with mapl_HConfigAsTime in new_ExtDataRule, which robustly
  handles date-only strings like '2008-01-01' (valid ISO 8601 but rejected by
  ESMF_TimeSet(timeString=))
- ExtDataConfig/sort_rules_by_start: use mapl_HConfigAsTime directly, drop
  string intermediary and ESMF_TimeSet(timeString=) call
- ExtDataConfig/get_time_range: work with ESMF_Time array instead of StringVector,
  drop ESMF_TimeSet(timeString=) calls
- Add MAPL.hconfig to ExtData3G link dependencies
- string_to_esmf_time remains private to mapl3g_HConfigAs

Author: tclune

Apps/CMakeLists.txt

@@ -33,7 +33,7 @@ install(
   DESTINATION bin/forcing_converter)
 
 ecbuild_add_executable (TARGET Regrid_Util.x SOURCES Regrid_Util/Regrid_Util.F90)
-target_link_libraries (Regrid_Util.x PRIVATE MAPL MAPL.base MAPL.profiler MPI::MPI_Fortran ESMF::ESMF OpenMP::OpenMP_Fortran)
+target_link_libraries (Regrid_Util.x PRIVATE MAPL MAPL.base3g MAPL.profiler MPI::MPI_Fortran ESMF::ESMF OpenMP::OpenMP_Fortran)
 target_include_directories (Regrid_Util.x PRIVATE $<BUILD_INTERFACE:${MAPL_SOURCE_DIR}/include>)
 
 if (PFUNIT_FOUND)

base/mapl_tree.py Apps/mapl_tree.pybase/mapl_tree.py renamed to Apps/mapl_tree.py

@@ -17,7 +17,7 @@ set(srcs
 
 esma_add_library(${this}
   SRCS ${srcs}
-  DEPENDENCIES MAPL.field MAPL.field_bundle MAPL.geom MAPL.pfio MAPL.base MAPL.shared MAPL.esmf_utils MAPL.hconfig_utils MAPL.regridder_mgr GFTL::gftl-v2 MAPL.base
+  DEPENDENCIES MAPL.field MAPL.field_bundle MAPL.geom MAPL.pfio MAPL.base3g MAPL.shared MAPL.esmf_utils MAPL.hconfig_utils MAPL.regridder_mgr GFTL::gftl-v2
   TYPE SHARED
   )
 

base/mapl_vlist.py Apps/mapl_vlist.pybase/mapl_vlist.py renamed to Apps/mapl_vlist.py

@@ -2,7 +2,6 @@
 module mapl3g_FieldBundleWrite
    use ESMF
    use pFIO
-   use MAPL_VerticalDataMod
    use pFIO_ClientManagerMod, only: o_Clients
    use MAPL_ExceptionHandling
    use mapl3g_GeomPFIO

GeomIO/CMakeLists.txt

@@ -3,11 +3,8 @@
 module MAPL2
    use MAPL_ExceptionHandling
    use MAPL_ShmemMod
-   use MAPL_MemUtilsMod
+   use mapl_base3g
    use MAPL_SimpleBundleMod
-   use MAPL_ServerManager
-   use MAPL_FileMetadataUtilsMod
-   use MAPL_VerticalDataMod
    use pFIO
    use MAPL_GridCompsMod
    use mapl3g_OpenMP_Support, only : MAPL_get_current_thread => get_current_thread

GeomIO/FieldBundleWrite.F90

@@ -1,14 +1,7 @@
 esma_set_this (OVERRIDE MAPL.base)
 
 set (srcs
-  FileMetadataUtilities.F90
-  FileMetadataUtilitiesVector.F90       SimpleBundleMod.F90
-  MAPL_ESMFTimeVectorMod.F90
-                                        MAPL_VerticalInterpMod.F90
-                                        MAPL_VerticalMethods.F90
-  ServerManager.F90
-  getrss.c  memuse.c
-  TimeStringConversion.F90
+  SimpleBundleMod.F90
   )
 
 # Comms.F90, StringTemplate.F90, SatVapor.F90 have been moved to base3g/