Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete code in VariableSpec.F90 #3406

Open
tclune opened this issue Feb 11, 2025 · 0 comments
Open

Delete code in VariableSpec.F90 #3406

tclune opened this issue Feb 11, 2025 · 0 comments
Assignees
@tclune
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related 🛠️ Refactor This is code refactoring

Comments

@tclune
Copy link
Collaborator

tclune commented Feb 11, 2025

This code in VariableSpec.F90:

      _SET_OPTIONAL(standard_name)
      _SET_OPTIONAL(itemtype)

      _SET_OPTIONAL(substate)
      _SET_OPTIONAL(service_items)
      _SET_OPTIONAL(default_value)
      _SET_OPTIONAL(vertical_dim_spec)
      _SET_OPTIONAL(attributes)
      _SET_OPTIONAL(bracket_size)
      _SET_OPTIONAL(dependencies)

should mostly be unnecessary now that everything uses StateItemAspect. But needs to be tested.
@tclune tclune added 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related 🛠️ Refactor This is code refactoring labels Feb 11, 2025
@tclune tclune self-assigned this Feb 11, 2025
tclune added a commit that referenced this issue Feb 11, 2025
@tclune
Fixes #3406
5ac16a5 
Not quite as much cleanup possible as I had imagined.
tclune added a commit that referenced this issue Feb 12, 2025
@tclune
Merge branch 'release/MAPL-v3' into feature/tclune/#3406-cleanup
dca7dfa
pchakraborty added a commit that referenced this issue Feb 12, 2025
@pchakraborty
Merge pull request #3408 from GEOS-ESM/feature/tclune/#3406-cleanup
c493089 
Feature/tclune/#3406 cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tclune tclune

Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related 🛠️ Refactor This is code refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tclune