Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename MAPL_RunChild and MAPL_RunChildren #3415

Open
tclune opened this issue Feb 12, 2025 · 0 comments
Open

Rename MAPL_RunChild and MAPL_RunChildren #3415

tclune opened this issue Feb 12, 2025 · 0 comments
Assignees
@JulesKouatchou
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related 🛠️ Refactor This is code refactoring

Comments

@tclune
Copy link
Collaborator

tclune commented Feb 12, 2025

Enforce convention MAPL_GridCompRunChild etc.

Need to propagate to all uses across MAPL3 directories. Tedious but simple.

The tricky bit is that we want to keep MAPL_RunChild for legacy interfacing. That procedure should call MAPL_GridCompRun() and print out a warning that it is an obsolete interface.
@tclune tclune added 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related 🛠️ Refactor This is code refactoring labels Feb 12, 2025
tclune added a commit that referenced this issue Feb 14, 2025
@tclune
Fixes #3429 and #3415 and #3413
8b38e19
pchakraborty added a commit that referenced this issue Feb 14, 2025
@pchakraborty
Merge pull request #3431 from GEOS-ESM/feature/tclune/#3429-user-leve…
780e1f6 
…l-add-varspec

Fixes #3429 and #3415 and #3413
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JulesKouatchou JulesKouatchou

Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related 🛠️ Refactor This is code refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JulesKouatchou @tclune