Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change refTime to refTime_offset in ChildSpec #3422

Open
tclune opened this issue Feb 12, 2025 · 0 comments
Open

Change refTime to refTime_offset in ChildSpec #3422

tclune opened this issue Feb 12, 2025 · 0 comments
Assignees
@darianboggs
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related 🛠️ Refactor This is code refactoring

Comments

@tclune
Copy link
Collaborator

tclune commented Feb 12, 2025

I was mislead by ESMF documentation, and we need the actual refTime for user clocks to be something more realistic than 900s AD.

Needs the following changes:

  • Change refTime as an ESMF_Time to refTime_offset as an ESMF_TimeInterval
  • Change the schema for the user to specify refTime_offset instead of refTime
  • Modify the analogous component in OuterMetaComponent refTime to be refTime_offset
  • Modify OuterMetComponent/add_child_by_spec.F90 refTime ==> refTime_offset
  • In OuterMetaComponent/initialize_set_clock.F90: user_refTime = outer_refTime + refTime_offset
@tclune tclune added 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related 🛠️ Refactor This is code refactoring labels Feb 12, 2025
This was referenced Feb 19, 2025
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darianboggs darianboggs

Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related 🛠️ Refactor This is code refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/wdboggs/3422 ref time to ref offset GEOS-ESM/MAPL
2 participants
@tclune @darianboggs