Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/wdboggs/3422 ref time to ref offset #3439

Closed

Conversation

darianboggs
Copy link
Contributor

@darianboggs darianboggs commented Feb 19, 2025

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

This PR changes the refTime component in MAPL derived types to refTime_offset, and it changes the value of refTime set in the user ESMF_Clock by OuterMetaComponent%initialize_set_clock() according to the value of refTime for the outer clock and the user refTime_offset.

Related Issue

Closes #3422

@darianboggs darianboggs added 🎁 New Feature This is a new feature 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related labels Feb 19, 2025
@darianboggs darianboggs requested a review from tclune February 19, 2025 20:03
@darianboggs darianboggs self-assigned this Feb 19, 2025
@darianboggs darianboggs requested a review from a team as a code owner February 19, 2025 20:03
@darianboggs
Copy link
Contributor Author

Canceling

@darianboggs darianboggs removed the request for review from tclune February 19, 2025 20:09
@darianboggs darianboggs reopened this Feb 19, 2025
@darianboggs darianboggs marked this pull request as draft February 19, 2025 20:15
@darianboggs darianboggs changed the base branch from main to release/MAPL-v3 February 19, 2025 20:16
@darianboggs darianboggs added the 🚫 Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs label Feb 19, 2025
Copy link

This PR is being prevented from merging because you have added one of our blocking labels: 🚫 Contingent - DNA. You'll need to remove it before this PR can be merged.

@darianboggs
Copy link
Contributor Author

Since this PR had the wrong base, I am closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related 🎁 New Feature This is a new feature 🚫 Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change refTime to refTime_offset in ChildSpec
1 participant