From 4c21ecddb6eaf8c8e89135e48486474d26fb3b9c Mon Sep 17 00:00:00 2001 From: Garrett Stevens Date: Fri, 7 Feb 2025 13:52:49 -0700 Subject: [PATCH] Bugfix: don't remove jobs if name doesn't exist --- .../jobs-management/src/JobsListWidget/model.ts | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/plugins/jobs-management/src/JobsListWidget/model.ts b/plugins/jobs-management/src/JobsListWidget/model.ts index 3bde63c78a..6f89d05eb2 100644 --- a/plugins/jobs-management/src/JobsListWidget/model.ts +++ b/plugins/jobs-management/src/JobsListWidget/model.ts @@ -62,9 +62,11 @@ export function stateModelFactory(_pluginManager: PluginManager) { */ removeJob(jobName: string) { const indx = self.jobs.findIndex(job => job.name === jobName) - const removed = self.jobs[indx] - self.jobs.splice(indx, 1) - return removed + if (indx === -1) { + return undefined + } + const removed = self.jobs.splice(indx, 1) + return removed[0] }, /** * #action @@ -110,9 +112,11 @@ export function stateModelFactory(_pluginManager: PluginManager) { */ removeQueuedJob(jobName: string) { const indx = self.queued.findIndex(job => job.name === jobName) - const removed = self.queued[indx] - self.queued.splice(indx, 1) - return removed + if (indx === -1) { + return undefined + } + const removed = self.queued.splice(indx, 1) + return removed[0] }, /** * #action