Updates

Author: cmdcolin

plugins/wiggle/src/MultiWiggleAdapter/MultiWiggleAdapter.test.ts

@@ -359,4 +359,121 @@ describe('MultiWiggleAdapter.getSources', () => {
       expect(sources1).toEqual(sources2)
     })
   })
+
+  describe('source uniqueness', () => {
+    it('should keep sources unique when all are different', async () => {
+      adapter = new MultiWiggleAdapter(configSchema.create({}))
+
+      adapter.getAdapters = jest.fn().mockResolvedValue([
+        {
+          source: 'source-1',
+          type: 'BigWigAdapter',
+          bigWigLocation: { uri: 'http://example.com/data/file1.bw' },
+          dataAdapter: {} as any,
+        },
+        {
+          source: 'source-2',
+          type: 'BigWigAdapter',
+          bigWigLocation: { uri: 'http://example.com/data/file2.bw' },
+          dataAdapter: {} as any,
+        },
+        {
+          source: 'source-3',
+          type: 'BigWigAdapter',
+          bigWigLocation: { uri: 'http://example.com/data/file3.bw' },
+          dataAdapter: {} as any,
+        },
+      ])
+
+      const sources = await adapter.getSources([])
+
+      expect(sources).toHaveLength(3)
+      expect(sources[0]!.source).toBe('source-1')
+      expect(sources[1]!.source).toBe('source-2')
+      expect(sources[2]!.source).toBe('source-3')
+
+      // Verify all sources are unique
+      const uniqueSourcesSet = new Set(sources.map(s => s.source))
+      expect(uniqueSourcesSet.size).toBe(3)
+    })
+
+    it('should make duplicate sources unique by appending counter', async () => {
+      adapter = new MultiWiggleAdapter(configSchema.create({}))
+
+      adapter.getAdapters = jest.fn().mockResolvedValue([
+        {
+          source: 'duplicate',
+          type: 'BigWigAdapter',
+          bigWigLocation: { uri: 'http://example.com/data/file1.bw' },
+          dataAdapter: {} as any,
+        },
+        {
+          source: 'duplicate',
+          type: 'BigWigAdapter',
+          bigWigLocation: { uri: 'http://example.com/data/file2.bw' },
+          dataAdapter: {} as any,
+        },
+        {
+          source: 'duplicate',
+          type: 'BigWigAdapter',
+          bigWigLocation: { uri: 'http://example.com/data/file3.bw' },
+          dataAdapter: {} as any,
+        },
+      ])
+
+      const sources = await adapter.getSources([])
+
+      expect(sources).toHaveLength(3)
+      expect(sources[0]!.source).toBe('duplicate')
+      expect(sources[1]!.source).toBe('duplicate-1')
+      expect(sources[2]!.source).toBe('duplicate-2')
+
+      // Verify all sources are unique
+      const uniqueSourcesSet = new Set(sources.map(s => s.source))
+      expect(uniqueSourcesSet.size).toBe(3)
+    })
+
+    it('should handle mixed duplicate and unique sources', async () => {
+      adapter = new MultiWiggleAdapter(configSchema.create({}))
+
+      adapter.getAdapters = jest.fn().mockResolvedValue([
+        {
+          source: 'unique1',
+          type: 'BigWigAdapter',
+          bigWigLocation: { uri: 'http://example.com/data/file1.bw' },
+          dataAdapter: {} as any,
+        },
+        {
+          source: 'duplicate',
+          type: 'BigWigAdapter',
+          bigWigLocation: { uri: 'http://example.com/data/file2.bw' },
+          dataAdapter: {} as any,
+        },
+        {
+          source: 'duplicate',
+          type: 'BigWigAdapter',
+          bigWigLocation: { uri: 'http://example.com/data/file3.bw' },
+          dataAdapter: {} as any,
+        },
+        {
+          source: 'unique2',
+          type: 'BigWigAdapter',
+          bigWigLocation: { uri: 'http://example.com/data/file4.bw' },
+          dataAdapter: {} as any,
+        },
+      ])
+
+      const sources = await adapter.getSources([])
+
+      expect(sources).toHaveLength(4)
+      expect(sources[0]!.source).toBe('unique1')
+      expect(sources[1]!.source).toBe('duplicate')
+      expect(sources[2]!.source).toBe('duplicate-1')
+      expect(sources[3]!.source).toBe('unique2')
+
+      // Verify all sources are unique
+      const uniqueSourcesSet = new Set(sources.map(s => s.source))
+      expect(uniqueSourcesSet.size).toBe(4)
+    })
+  })
 })

plugins/wiggle/src/MultiWiggleAdapter/MultiWiggleAdapter.ts

@@ -155,11 +155,19 @@ export default class MultiWiggleAdapter extends BaseFeatureDataAdapter {
   // something, but it is static for this particular multi-wiggle adapter type
   async getSources(_regions: Region[]) {
     const adapters = await this.getAdapters()
+    const seenSources = new Map<string, number>()
+
     return adapters.map(({ dataAdapter, source, name, type, ...rest }) => {
+      const count = (seenSources.get(source) ?? 0) + 1
+      seenSources.set(source, count)
+
+      // Append counter to duplicates to ensure uniqueness
+      const uniqueSource = count > 1 ? `${source}-${count - 1}` : source
+
       return {
         ...rest,
         name: name || getFilenameFromFileLocation({ type, ...rest }) || source,
-        source,
+        source: uniqueSource,
         type,
       }
     })