`assemblyManager.get()` return value does not evaluate to correct type

[garrettjstevens]

If you take a simple plugin like this:

import Plugin from '@jbrowse/core/Plugin'
import PluginManager from '@jbrowse/core/PluginManager'
import {
  type AbstractSessionModel,
  isAbstractMenuManager,
} from '@jbrowse/core/util'


export default class ApolloIntroPlugin extends Plugin {
  name = 'ApolloIntroPlugin'

  configure(pluginManager: PluginManager) {
    if (isAbstractMenuManager(pluginManager.rootModel)) {
      pluginManager.rootModel.appendToMenu('Add', {
        label: 'Widget',
        onClick: (session: AbstractSessionModel) => {
          const { assemblyManager } = session
          const assembly = assemblyManager.get('assemblyName')
          console.log(assembly)
        },
      })
    }
  }
}

And run a type-aware lint on it, you get output like this:

/path/to/plugin/src/index.ts
  18:17  error  Unsafe assignment of an error typed value  @typescript-eslint/no-unsafe-assignment

✖ 1 problem (1 error, 0 warnings)

And if you hover over assembly in an editor, it shows the type as any.

What's odd is this error does not appear in the current main branch of Apollo, but when I try to reproduce it outside of the Apollo repository, I always get the error, no matter how much I try to match the dependency versions. And when I upgrade @jbrowse/core in the Apollo repository, this same error appears.

Reproducible repo at: https://github.com/garrettjstevens/jbrowse-plugin-5568-repro

[cmdcolin]

interesting...i believe this is due to using the newer @jbrowse/mobx-state-tree version that v4.3.0 was not built with

the @jbrowse/core .d.ts files will say import("@jbrowse/mobx-state-tree/dist/internal").NonEmptyObject but i made new changes in @jbrowse/mobx-state-tree@v5.8.7 so it does not have that mapping, instead it is import("@jbrowse/mobx-state-tree").NonEmptyObject

That is my guess right now. once we release a new jbrowse version, the .d.ts file of @jbrowse/core will correspond with the new @jbrowse/mobx-state-tree version also

might be able to downgrade @jbrowse/mobx-state-tree to fix

[garrettjstevens]

I tried pinning @jbrowse/core to v4.1.1 (which I thought was a working version) and @jbrowse/mobx-state-tree to v5.5.0, which was the current version when v4.1.1 was released, but I'm still getting the lint error.