Fix detection of present on separate GPU for the Wayland dmabuf case #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmshanah
changed the title
WaylandWindowSystem::m_presentOnSameGpu is set to true on initialisation and was never being set to false in the case where the present drm device was different from the render device.
kmshanah
force-pushed
the
fix-dma-present-on-distinct-gpu
branch
from
8d918e1 to
169c3bb
Compare
JakeMerdichAMD
approved these changes
Jan 31, 2025
There was a problem hiding this comment.
Nice catch, thank you! We missed this, though I'm a bit surprised the dmabuf modifier negotiation didn't force us into a linear image mode regardless.
This has been ported internally as well and will be in an upcoming release for both AMDVLK and AMDGPU-PRO.
Edit: sorry, seems like someone else with approval permissions will have to do this. This might take a few days.
ninelore
added a commit
to ninelore/flake
that referenced
this pull request
Feb 2, 2025
jinjianrong
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WaylandWindowSystem::m_presentOnSameGpu is set to true on initialisation and was never being set to false in the case where the presenting drm device was different from the render device.
Fixes GPUOpen-Drivers/AMDVLK#393