Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve validation for ALNs upon workbook uploads #4700

Open
Tracked by #4658
phildominguez-gsa opened this issue Feb 12, 2025 · 1 comment · May be fixed by #4701
Open
Tracked by #4658

Improve validation for ALNs upon workbook uploads #4700

phildominguez-gsa opened this issue Feb 12, 2025 · 1 comment · May be fixed by #4701
Assignees
@phildominguez-gsa

Comments

@phildominguez-gsa
Copy link
Contributor

phildominguez-gsa commented Feb 12, 2025 •
edited
Loading

Relevant text from parent ticket:

Currently only regex-based validation is done for ALNs (extensions must have 3 digits, for example). Instead, we can validate that only ALNs found in FederalProgramNames.json are accepted.
@phildominguez-gsa phildominguez-gsa mentioned this issue Feb 12, 2025
Open
@github-project-automation github-project-automation bot moved this to Triage in FAC Feb 12, 2025
@phildominguez-gsa phildominguez-gsa moved this from Triage to In Progress in FAC Feb 12, 2025
@phildominguez-gsa phildominguez-gsa self-assigned this Feb 12, 2025
@phildominguez-gsa phildominguez-gsa linked a pull request Feb 12, 2025 that will close this issue
Open
18 tasks
@phildominguez-gsa
Copy link
Contributor Author

@danswick After discussing with Hassan, we came to the conclusion that we should probably hold off on this. ALNs are updated/added all the time, and we only update our list once in a blue moon. Because of this, we allow users to manually type in program names in case the ALN they're using isn't in our list. Will close this if no objection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phildominguez-gsa phildominguez-gsa

Labels
None yet
Projects
FAC
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improving ALN workbook validation GSA-TTS/FAC
1 participant
@phildominguez-gsa