DIGITAL-99: Allow all validation commands to run during validate:all.

Author: mattsqd

.github/workflows/validation-run.yml

@@ -49,26 +49,23 @@ jobs:
                 run: |
                     # Initialize status variables to 0
                     status1=0
-                    status2=0
-                    status3=0
-                    status4=0
-                    status5=0
 
-                    # Run all commands and capture their exit statuses
-                    vendor/bin/robo validate:branch-name ${{ steps.extract_branch.outputs.branch }} || status1=$? || status1=0
-                    vendor/bin/robo validate:composer-lock || status3=$? || status3=0
-                    vendor/bin/robo validate:coding-standards || status2=$? || status2=0
-                    set -x
-                    vendor/bin/twig-cs-fixer lint || status4=$? || status4=0
-                    vendor/bin/phpstan --memory-limit=-1 --no-progress || status5=$? || status5=0
-                    set +x;
+                    ROBO_VALIDATE_BRANCH_NAME=${{ steps.extract_branch.outputs.branch }} vendor/bin/robo validate:all non_pr
 
-                    # Exit with a non-zero status if any command failed
-                    if [ "$status1" -ne 0 ] || [ "$status2" -ne 0 ] || [ "$status3" -ne 0 ] || [ "$status4" -ne 0 ] || [ "$status5" -ne 0 ]; then
+                    # Exit with a non-zero status if the command failed
+                    if [ "$status1" -ne 0 ]; then
                       exit 1
                     fi
 
             -   name: Validate pull requests
                 if: github.event_name == 'pull_request'
                 run: |
-                    vendor/bin/robo validate:commit-messages --target-branch="${{ github.base_ref }}" --current-branch="${{ github.head_ref }}"
+                    # Initialize status variables to 0
+                    status1=0
+
+                    ROBO_VALIDATE_TARGET_BRANCH="${{ github.base_ref }}" ROBO_VALIDATE_CURRENT_BRANCH="${{ github.head_ref }}" vendor/bin/robo validate:all only_pr
+
+                    # Exit with a non-zero status if the command failed
+                    if [ "$status1" -ne 0 ]; then
+                      exit 1
+                    fi

RoboFile.php

@@ -273,4 +273,57 @@ public function reTagRelease(
         return new ResultData();
     }
 
+    /**
+     * Run PHPStan validation.
+     *
+     * @command validate:phpstan
+     */
+    public function validatePhpstan(): ResultData
+    {
+        if (!$this->taskExec('vendor/bin/phpstan')
+            ->option('memory-limit', '-1', '=')
+            ->run()->wasSuccessful()) {
+            $this->printError('PHPStan errors found');
+            return new ResultData(ResultData::EXITCODE_ERROR);
+        }
+        $this->sayWithWrapper('SUCCESS: No PHPStan errors found.');
+        return new ResultData();
+    }
+
+    /**
+     * Run Twig validation.
+     *
+     * @command validate:twig
+     */
+    public function validateTwig(): ResultData
+    {
+        if (!$this->taskExec('vendor/bin/twig-cs-fixer')
+            ->arg('lint')
+            ->run()->wasSuccessful()) {
+            $this->printError('Twig errors found. Use vendor/bin/twig-cs-fixer lint --fix to automatically fix.');
+            return new ResultData(ResultData::EXITCODE_ERROR);
+        }
+        $this->sayWithWrapper('SUCCESS: No PHPStan errors found.');
+        return new ResultData();
+    }
+
+    /**
+     * Say a message but with a '---' wrapper around it.
+     */
+    protected function sayWithWrapper($message)
+    {
+        $this->say('');
+        $this->say(str_repeat('-', strlen($message)));
+        $this->say($message);
+        $this->say(str_repeat('-', strlen($message)));
+        $this->say('');
+    }
+
+    /**
+     * Print an error message.
+     */
+    protected function printError($message)
+    {
+        $this->yell($message, 40, 'red');
+    }
 }

composer.lock

@@ -72,3 +72,4 @@ d0ca998c567e8cc218ee57bb5c9b6679|cathybaptista|feature/DIGITAL-119-configure-ima
 6b5963bf3c6740285c129be6d6273aed|cathybaptista|feature/DIGITAL-119-configure-images|Thu Feb  6 11:06:14 EST 2025|./composer.sh require drupal/edit_media_modal
 caeb4cc7f30e1f80c7425f9c3fcf8a98|Oscar Merida|feature/DIGITAL-89-linkit|Wed Feb  5 16:40:40 EST 2025|./composer.sh require drupal/linkit:^7.0
 c063010712247ba9dfd709c97fccb648|Oscar Merida|feature/DIGITAL-89-linkit|Thu Feb  6 16:27:25 EST 2025|./composer.sh require drupal/linkit:^7.0
+baf396b85c3bcb4a0f123cfa702e1088|Matt Poole|feature/DIGITAL-99-robo-standards|Mon Feb 10 14:12:29 EST 2025|./composer.sh update mattsqd/robovalidate

composer.log

@@ -22,3 +22,12 @@ command:
           - 'semantic_end_0|release'
           # Matches a branch named 'stage' (MOD FROM DEFAULTS).
           - 'explicit|stage'
+    all:
+      options:
+        commands:
+          - {robo_command: 'validate:coding-standards', label: 'Coding Standards'}
+          - {robo_command: 'validate:composer-lock', label: 'Composer Lock File'}
+          - {robo_command: 'validate:commit-messages', label: 'Commit Messages', only_pr: 1}
+          - {robo_command: 'validate:branch-name', label: 'Branch Name'}
+          - {robo_command: 'validate:phpstan', label: 'PHP Stan'}
+          - {robo_command: 'validate:twig', label: 'Twig Standards'}