Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

streamlined, simplified validation scripts #574

Open
rmandelb opened this issue Jul 1, 2014 · 3 comments
Open

streamlined, simplified validation scripts #574

rmandelb opened this issue Jul 1, 2014 · 3 comments
Labels
cleanup Non-functional changes to make the code better tests Related to the test suite

Comments

@rmandelb
Copy link
Member

rmandelb commented Jul 1, 2014

As discussed in #568 (comment) and subsequent comments, we may want to make a simplified version of the scripts that did the main GalSim validation tests for the GalSim paper, so that we can check that they are still okay when we tag a new version. The latest proposal on that issue was to focus on the 3 key tests that we did, for just the default values of GSParams / interpolants. More discussion and/or work can happen here on this issue.
rmandelb added a commit that referenced this issue Mar 24, 2016
@rmandelb
update test_interpolants_parametric.py to work with GalSim v1.4
c753c23 
(#574)
@rmjarvis rmjarvis added tests Related to the test suite and removed core labels Nov 21, 2016
@rmjarvis rmjarvis mentioned this issue Mar 12, 2018
Merged
rmjarvis pushed a commit that referenced this issue May 14, 2018
@rmandelb @rmjarvis
update test_interpolants_parametric.py to work with GalSim v1.4
2ab7b04 
(#574)
rmjarvis added a commit that referenced this issue May 14, 2018
@rmjarvis
update test_interpolants_parametric.py to work with GalSim v2.0 (#574)
dda504c
@rmjarvis
Copy link
Member

Propose closing this as an admission that, while a good idea, this is never going to happen.

@rmandelb
Copy link
Member Author

I'd prefer not to give up on this one, though I admit that it being open for 8 years is not promising. It could be a good starter project...

@rmjarvis
Copy link
Member

lol ok. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup Non-functional changes to make the code better tests Related to the test suite
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rmjarvis @rmandelb