Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How should we behave on Ctrl+C? #36

Open
5225225 opened this issue Nov 11, 2023 · 3 comments
Open

How should we behave on Ctrl+C? #36

5225225 opened this issue Nov 11, 2023 · 3 comments
Labels
help wanted Extra attention is needed question Further information is requested

Comments

@5225225
Copy link
Contributor

5225225 commented Nov 11, 2023

I was thinking about #28 and checked out how cargo mommy fuzz works at the moment. A fuzzing failure works, since it exits with nonzero status, but fuzzers typically run indefinitely (or until you get bored, rather. Unless you set a timeout), so you ^C them, which leads mommy to have no output.

Not outputting anything for a normal command seems fine (unless you wanted to make a quip about how impatient the user is, which would be a third response type I think), but at least for a fuzzer which generally always will be exit with ^C, not doing anything doesn't seem great. Treating it as a success would be fine?

Making this issue mainly to get feedback on how we should act here, I have no firm opinions.

@Gankra
Copy link
Owner

Gankra commented Nov 12, 2023

this is a good question and i'm not sure the answer...

@Gankra Gankra added help wanted Extra attention is needed question Further information is requested labels Nov 12, 2023
@BLucky-gh
Copy link

This could probably be done by only saying something if the command has been running for longer than a configurable amount of time, and then write the comment about being impatient or smth in the SIGINT handler

@workingjubilee
Copy link
Contributor

Preferably the decision is made before entering the signal handler, so that there is no accidental use of async-signal-unsafe functions, though I suppose they're unlikely to cause problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants