Fixed not PR comments for documentation

Signed-off-by: Gaurav Chandani <[email protected]>
Gaurav614 · Feb 12, 2024 · aa6025a · aa6025a
1 parent 6843eb2
commit aa6025a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/server/src/main/java/org/opensearch/cluster/routing/allocation/AllocationService.java b/server/src/main/java/org/opensearch/cluster/routing/allocation/AllocationService.java
@@ -577,6 +577,7 @@ private void allocateExistingUnassignedShards(RoutingAllocation allocation) {
             ExistingShardsAllocator allocator = existingShardsAllocators.get(ShardsBatchGatewayAllocator.ALLOCATOR_NAME);
             allocator.allocateAllUnassignedShards(allocation, true);
             allocator.afterPrimariesBeforeReplicas(allocation);
+            // Replicas Assignment
             allocator.allocateAllUnassignedShards(allocation, false);
             return;
         }
@@ -704,7 +705,7 @@ private ExistingShardsAllocator getAllocatorForShard(ShardRouting shardRouting,
         final String allocatorName = ExistingShardsAllocator.EXISTING_SHARDS_ALLOCATOR_SETTING.get(
             routingAllocation.metadata().getIndexSafe(shardRouting.index()).getSettings()
         );
-        ExistingShardsAllocator existingShardsAllocator = existingShardsAllocators.get(allocatorName);
+        final ExistingShardsAllocator existingShardsAllocator = existingShardsAllocators.get(allocatorName);
         return existingShardsAllocator != null ? existingShardsAllocator : new NotFoundAllocator(allocatorName);
     }
 

diff --git a/server/src/main/java/org/opensearch/cluster/routing/allocation/ExistingShardsAllocator.java b/server/src/main/java/org/opensearch/cluster/routing/allocation/ExistingShardsAllocator.java
@@ -70,15 +70,10 @@ public interface ExistingShardsAllocator {
      * {@link ExistingShardsAllocator#allocateAllUnassignedShards(RoutingAllocation, boolean)} method.
      * The default implementation of this method is not optimized and assigns shards one by one.
      *
-     * If enable to true then it expects all indices of the shard to use same {@link ExistingShardsAllocator}, otherwise
-     * Allocation Service will fallback to default implementation i.e. {@link ExistingShardsAllocator#allocateUnassigned(ShardRouting, RoutingAllocation, UnassignedAllocationHandler)}
-     *
      * If no plugin overrides {@link ExistingShardsAllocator} then default implementation will be use for it , i.e,
-     * {@link ShardsBatchGatewayAllocator}. Right now even if plugin implements it, AllocationService will run the
-     * default implementation to enable Batch mode of assignment
+     * {@link ShardsBatchGatewayAllocator}.
      *
-     * TODO: Currently its implementation is WIP for GatewayAllocator so setting enabling wont have any effect
-     * https://github.com/opensearch-project/OpenSearch/issues/5098
+     * This setting is experimental at this point.
      */
     Setting<Boolean> EXISTING_SHARDS_ALLOCATOR_BATCH_MODE = Setting.boolSetting(
         "cluster.allocator.existing_shards_allocator.batch_enabled",