Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up nonParametricPV #8

Closed
slamao opened this issue Feb 14, 2025 · 0 comments · Fixed by #9
Closed

Speed up nonParametricPV #8

slamao opened this issue Feb 14, 2025 · 0 comments · Fixed by #9

Comments

@slamao
Copy link
Collaborator

slamao commented Feb 14, 2025

When using large vectors, the yardstick::ppv_vec and yardstick::npv_vec get really slow, see below an example with vectors of length 50k:

Image

Remove those functions and use formulas to calculate the PVs.
slamao added a commit that referenced this issue Feb 14, 2025
@slamao
#8: remove yardstick
017e0c0
@slamao slamao mentioned this issue Feb 14, 2025
Merged
slamao added a commit that referenced this issue Feb 14, 2025
@slamao
#8: version bump
5ab83b8
slamao added a commit that referenced this issue Feb 14, 2025
@slamao
#8: update sensSpec plot and calculation in a similar fashion as in #7
ee12893
@slamao slamao closed this as completed in #9 Feb 17, 2025
slamao added a commit that referenced this issue Feb 17, 2025
@slamao
#8: remove yardstick (#9)
43f542e 
Close #8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#8: remove yardstick Genentech/stats4phc
1 participant
@slamao