-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A Place to see the all users evaluations and letting user makes edits #26
Comments
The design will still need some changes that @markoprljic will take care of. |
All design revisions have been amended. |
@HrithikSampson will do the frontend, while @mmahdigh will support the backend of this feature. |
Hi @maryjaf , it is ready to be tested |
Screen.Recording.2025-01-20.at.12.53.42.PM.mov |
|
Figma: Current view: |
for the first point @maryjaf , the filter is done if it belongs to any pair of project |
I don't get your point, I entered the repo name that both project belong it but as you can see in the video by setting repo name nothing is shown Screen.Recording.2025-01-20.at.3.37.40.PM.mov |
@maryjaf , in the design it was showing the project it was filtering on not the repo. Like I remember that notify-server and key-server is the project in the repo, so filtering is done on the project |
Hi @maryjaf , I can see the score fluctuating but it is saving it, I think |
Please take a look at this screen record, now the change of "comment" is saved but the "score" isn't saved correctly Screen.Recording.2025-01-20.at.5.47.32.PM.mov |
thanks @HrithikSampson |
No it's not approved @maryjaf @HrithikSampson , filtering should filter the parent repo, not the dependency. |
Thanks @HrithikSampson 2 & 4 have been fixed.
|
Could you recheck the repo search functionality? I think it must be working now. |
Thanks,the search problem has been fixed. only edit problem remains. |
@mmahdigh please take a look |
When in edit flow I set a minus score after saving the change, it is changed to positive number, please take a look at below screen record Screen.Recording.2025-01-21.at.5.48.01.PM.mov |
It has been fixed |
resolved |
Screen.Recording.2025-01-21.at.6.47.20.PM.mov |
I found two more issues related to this edit, unfortunately:
Screen.Recording.2025-01-21.at.8.05.50.PM.mov
Screen.Recording.2025-01-21.at.8.07.59.PM.mov |
Resolved |
Design
https://www.figma.com/design/Sp4UCUX5pDT9SADoezxu6L/Pairwise--%3E-Deep-Funding?node-id=5467-4946&t=ptVXLgKdYuOnvKlD-4
Acceptance Criteria
Read More
loads the content by expanding the card.The text was updated successfully, but these errors were encountered: