Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A Place to see the all users evaluations and letting user makes edits #26

Open
6 tasks
MoeNick opened this issue Jan 6, 2025 · 27 comments
Open
6 tasks
Assignees

Comments

@MoeNick
Copy link

MoeNick commented Jan 6, 2025

Design

Image
Image
https://www.figma.com/design/Sp4UCUX5pDT9SADoezxu6L/Pairwise--%3E-Deep-Funding?node-id=5467-4946&t=ptVXLgKdYuOnvKlD-4

Acceptance Criteria

  • 2 Tabs, one is for my evaluations and one the other for my evaluations
  • My evaluation's right-side card should have an edit column
  • evaluation cards are shortened by 2 sentences and then having Read More loads the content by expanding the card.
  • Filter menu opens and results are filtered there.
  • Selected Filter should be like with design with the number of selected filters.
  • In the search field, typing in the repo names should be auto-completed.
    image
@MoeNick MoeNick converted this from a draft issue Jan 6, 2025
@MoeNick MoeNick moved this from Draft Issues to Design in Deep Funding Jan 6, 2025
@MoeNick
Copy link
Author

MoeNick commented Jan 13, 2025

The design will still need some changes that @markoprljic will take care of.

@markoprljic
Copy link

All design revisions have been amended.

@MoeNick MoeNick moved this from Design to Todo in Deep Funding Jan 13, 2025
@MoeNick
Copy link
Author

MoeNick commented Jan 13, 2025

@HrithikSampson will do the frontend, while @mmahdigh will support the backend of this feature.

@HrithikSampson HrithikSampson moved this from Todo to In Progress in Deep Funding Jan 16, 2025
@HrithikSampson
Copy link
Collaborator

Hi @maryjaf , it is ready to be tested

@HrithikSampson HrithikSampson moved this from In Progress to On Staging / QA in Deep Funding Jan 20, 2025
@maryjaf
Copy link

maryjaf commented Jan 20, 2025

  • 1- when I search by repo name although there are some evaluations for this repo but it isn't shown when I search
  • 2- and I think filter menu should be closed when I tap on every where in the page
Screen.Recording.2025-01-20.at.12.53.42.PM.mov

@HrithikSampson

@maryjaf
Copy link

maryjaf commented Jan 20, 2025

  • 3- when I try to edit the score and comment and tap on "save change" button
    my changes aren't saved

@HrithikSampson

@maryjaf
Copy link

maryjaf commented Jan 20, 2025

  • Selected Filter should be like with design with the number of selected filters.
  • 4- It isn't exactly like a design , please take a look at below pics @HrithikSampson

Figma:

Image

Current view:

Image

@HrithikSampson
Copy link
Collaborator

for the first point @maryjaf , the filter is done if it belongs to any pair of project

@HrithikSampson
Copy link
Collaborator

for the first point @maryjaf , the filter is done if it belongs to any pair of project

cc: @MoeNick

@maryjaf
Copy link

maryjaf commented Jan 20, 2025

for the first point @maryjaf , the filter is done if it belongs to any pair of project

I don't get your point, I entered the repo name that both project belong it but as you can see in the video by setting repo name nothing is shown

Screen.Recording.2025-01-20.at.3.37.40.PM.mov

@HrithikSampson
Copy link
Collaborator

@maryjaf , in the design it was showing the project it was filtering on not the repo. Like I remember that notify-server and key-server is the project in the repo, so filtering is done on the project

@HrithikSampson
Copy link
Collaborator

  • 3- when I try to edit the score and comment and tap on "save change" button
    my changes aren't saved

@HrithikSampson

Hi @maryjaf , I can see the score fluctuating but it is saving it, I think

@maryjaf
Copy link

maryjaf commented Jan 20, 2025

  • 3- when I try to edit the score and comment and tap on "save change" button
    my changes aren't saved
    @HrithikSampson

Hi @maryjaf , I can see the score fluctuating but it is saving it, I think

Please take a look at this screen record, now the change of "comment" is saved but the "score" isn't saved correctly

Screen.Recording.2025-01-20.at.5.47.32.PM.mov

@maryjaf
Copy link

maryjaf commented Jan 20, 2025

@maryjaf , in the design it was showing the project it was filtering on not the repo. Like I remember that notify-server and key-server is the project in the repo, so filtering is done on the project

thanks @HrithikSampson
cc: @MoeNick is it approved?

@MoeNick
Copy link
Author

MoeNick commented Jan 21, 2025

No it's not approved @maryjaf @HrithikSampson , filtering should filter the parent repo, not the dependency.
Filtering there is a way for filters evaluations based on the repo (category)
CC: @mmahdigh

@HrithikSampson
Copy link
Collaborator

Can you check @maryjaf , I couldnt solve the slider sign problem and for repo search I need some backend support @mmahdigh

@maryjaf
Copy link

maryjaf commented Jan 21, 2025

Thanks @HrithikSampson 2 & 4 have been fixed.

  • the problems related to search and edit ( 1 & 3) reman

@mmahdigh
Copy link
Collaborator

Thanks @HrithikSampson 2 & 4 have been fixed.

  • the problems related to search and edit ( 1 & 3) reman

Could you recheck the repo search functionality? I think it must be working now.

@maryjaf
Copy link

maryjaf commented Jan 21, 2025

  • 1- when I search by repo name although there are some evaluations for this repo but it isn't shown when I search

Thanks,the search problem has been fixed.

only edit problem remains.

@MoeNick
Copy link
Author

MoeNick commented Jan 21, 2025

@mmahdigh please take a look

@maryjaf
Copy link

maryjaf commented Jan 21, 2025

When in edit flow I set a minus score after saving the change, it is changed to positive number, please take a look at below screen record
but when I set a positive score every thing is saved correctly

@mmahdigh

Screen.Recording.2025-01-21.at.5.48.01.PM.mov

@maryjaf
Copy link

maryjaf commented Jan 21, 2025

When in edit flow I set a minus score after saving the change, it is changed to positive number, please take a look at below screen record
but when I set a positive score every thing is saved correctly

It has been fixed

@maryjaf
Copy link

maryjaf commented Jan 21, 2025

in evaluation page ,the location of the chart is not ideal for clearly displaying the number '1.' It appears misaligned

Image

Image

@maryjaf
Copy link

maryjaf commented Jan 21, 2025

in evaluation page ,the location of the chart is not ideal for clearly displaying the number '1.' It appears misaligned

resolved

@maryjaf
Copy link

maryjaf commented Jan 21, 2025

  • when I save changes, for a second the previous comment is shown
Screen.Recording.2025-01-21.at.6.47.20.PM.mov

@maryjaf
Copy link

maryjaf commented Jan 21, 2025

I found two more issues related to this edit, unfortunately:

  1. When I click on "Edit" for one evaluation, the edit view appears for my other evaluations as well.
Screen.Recording.2025-01-21.at.8.05.50.PM.mov
  1. When I edit and add a comment with less than 70 characters, the new comment is not saved correctly, but we show the 70-character error on the previous comment.
Screen.Recording.2025-01-21.at.8.07.59.PM.mov

@mmahdigh @HrithikSampson

@maryjaf
Copy link

maryjaf commented Jan 21, 2025

I found two more issues related to this edit, unfortunately:

Resolved

@maryjaf maryjaf moved this from On Staging / QA to Approved by QA in Deep Funding Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Approved by QA
Development

No branches or pull requests

5 participants