Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Optimism] Progress bar instead of rounds #65

Open
5 tasks
MoeNick opened this issue Jan 22, 2025 · 8 comments
Open
5 tasks

[Optimism] Progress bar instead of rounds #65

MoeNick opened this issue Jan 22, 2025 · 8 comments
Assignees

Comments

@MoeNick
Copy link

MoeNick commented Jan 22, 2025

Needed Changes

  • Progress bar in comparison round
  • No rounds in Repo page
  • No warning after the rounds
  • Alog decides when comparisosn are finished
  • When finished show a goodjob modal with a button to get back to repo page
@MoeNick MoeNick converted this from a draft issue Jan 22, 2025
@MoeNick MoeNick moved this from Todo to Design in Pairwise Multi Repo Backlog Jan 22, 2025
@MoeNick
Copy link
Author

MoeNick commented Jan 22, 2025

Hey @markoprljic can we have a version with back button and progress bar for OP fork?, I guess we had the draft in 0.0.2

@MoeNick
Copy link
Author

MoeNick commented Jan 23, 2025

@mmahdigh jan it's ready to go

@MoeNick MoeNick moved this from Design to Todo in Pairwise Multi Repo Backlog Jan 23, 2025
@MoeNick MoeNick moved this from Todo to In Progress in Pairwise Multi Repo Backlog Jan 30, 2025
@maryjaf maryjaf moved this from In Progress to Approved by QA in Pairwise Multi Repo Backlog Jan 30, 2025
@maryjaf
Copy link

maryjaf commented Jan 30, 2025

After completing 5 comparisons, the next round modal is shown

Screen.Recording.2025-01-30.at.4.58.55.PM.mov

@mmahdigh

@maryjaf maryjaf moved this from Approved by QA to On Staging / QA in Pairwise Multi Repo Backlog Jan 30, 2025
@mmahdigh
Copy link
Collaborator

After completing 5 comparisons, the next round modal is shown

Screen.Recording.2025-01-30.at.4.58.55.PM.mov
@mmahdigh

This is fixed & ready to be tested.

@maryjaf
Copy link

maryjaf commented Jan 31, 2025

After completing 5 comparisons, the next round modal is shown
Screen.Recording.2025-01-30.at.4.58.55.PM.mov
@mmahdigh

This is fixed & ready to be tested.

this problem has been fixed

@maryjaf
Copy link

maryjaf commented Jan 31, 2025

  • The progress bar hasn't reached the end yet, but we're showing the "Good Job" modal.

I think it's because I completed 30 items, but in reality, there were more than 30 comparisons.

Screen.Recording.2025-01-31.at.1.51.46.PM.mov

@maryjaf maryjaf moved this from On Staging / QA to Approved by QA in Pairwise Multi Repo Backlog Jan 31, 2025
@MoeNick
Copy link
Author

MoeNick commented Feb 8, 2025

@mmahdigh I think the last item has not been resolved.

@MoeNick MoeNick moved this from Approved by QA to Merged on Production in Pairwise Multi Repo Backlog Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged on Production
Development

No branches or pull requests

4 participants