Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements of DF version #66

Closed
8 of 11 tasks
MoeNick opened this issue Jan 22, 2025 · 17 comments
Closed
8 of 11 tasks

Improvements of DF version #66

MoeNick opened this issue Jan 22, 2025 · 17 comments
Assignees

Comments

@MoeNick
Copy link

MoeNick commented Jan 22, 2025

Top priority Have a version today:

  • My evaluations under header menu
  • Copy changes
  • my evaluation link in the repo page
  • having only one tab as My Evaluations
  • - [ ] copy change of my evaluations button on the comparison page
  • URL link for filtering the parent repo. (related to up)

On Mon:

  • lazy loading of my evaluations
  • making the sidebar fixed.
  • min 70 character error should be in black and when the user clicks it should be red, when the user has all the needed characters it should turn back again.
  • Remove the OP character for mobile view
  • Hovering statuses
@MoeNick
Copy link
Author

MoeNick commented Jan 22, 2025

@HrithikSampson I updated the priorities in the task list above

@HrithikSampson
Copy link
Collaborator

I tried to fix today's Issues along with lazy loading and removing side bar.

cc: @MoeNick @maryjaf

@HrithikSampson
Copy link
Collaborator

I forgot 1 small thing that is when the rounds are copleted that modal

@HrithikSampson
Copy link
Collaborator

I forgot 1 small thing that is when the rounds are copleted that modal

Sorry the title is same, no copy change required.

It is ready to be tested I think.

@maryjaf
Copy link

maryjaf commented Jan 23, 2025

I forgot 1 small thing that is when the rounds are copleted that modal

Sorry the title is same, no copy change required.

It is ready to be tested I think.

could you please tell me which items are ready for testing? all of them in description? @HrithikSampson

@maryjaf
Copy link

maryjaf commented Jan 23, 2025

  • when I tap on "view" button the filter related to repo name shouldn't be set like when I tap on my evaluation ?
Screen.Recording.2025-01-23.at.11.43.34.AM.mov

@MoeNick @HrithikSampson

@MoeNick
Copy link
Author

MoeNick commented Jan 23, 2025

  • when I tap on "view" button the filter related to repo name shouldn't be set like when I tap on my evaluation ?

Screen.Recording.2025-01-23.at.11.43.34.AM.mov
@MoeNick @HrithikSampson

Yes, it should send a param in URL to my evaluation page and filter the results.

@HrithikSampson
Copy link
Collaborator

I forgot 1 small thing that is when the rounds are copleted that modal

Sorry the title is same, no copy change required.
It is ready to be tested I think.

could you please tell me which items are ready for testing? all of them in description? @HrithikSampson

Image

@github-project-automation github-project-automation bot moved this from On Staging / QA to Approved by QA in Pairwise Multi Repo Backlog Jan 23, 2025
@HrithikSampson HrithikSampson moved this from Approved by QA to On Staging / QA in Pairwise Multi Repo Backlog Jan 23, 2025
@maryjaf
Copy link

maryjaf commented Jan 23, 2025

@HrithikSampson

  • lazy loading of my evaluations: pass

  • Remove the OP chracter for mobile view : pass

This was referenced Jan 23, 2025
@HrithikSampson
Copy link
Collaborator

@maryjaf , can you check once again

I changed the evaluation link for filtering and the Good Job modal after all rounds are complete

@maryjaf
Copy link

maryjaf commented Jan 23, 2025

Thank @HrithikSampson it has been fixed

@maryjaf maryjaf moved this from On Staging / QA to Approved by QA in Pairwise Multi Repo Backlog Jan 23, 2025
@MoeNick
Copy link
Author

MoeNick commented Jan 23, 2025

for URL params as @mmahdigh said we should be able to handle the sorting params as well.

@HrithikSampson
Copy link
Collaborator

HrithikSampson commented Jan 23, 2025

It is ready to be retested

cc: @MoeNick @maryjaf

This was referenced Jan 24, 2025
@HrithikSampson
Copy link
Collaborator

the remaining points are ready to be tested @maryjaf .

@maryjaf
Copy link

maryjaf commented Jan 27, 2025

  • min 70 character error should be in black and when the user clicks it should be red, when the user has all the needed characters it should turn back again.

The previous problem related to the color of box happens @HrithikSampson

Image

@HrithikSampson
Copy link
Collaborator

HrithikSampson commented Jan 27, 2025

Can you check this again I think I fixed it

  • min 70 character error should be in black and when the user clicks it should be red, when the user has all the needed characters it should turn back again.

The previous problem related to the color of box happens @HrithikSampson

Image

@maryjaf
Copy link

maryjaf commented Jan 27, 2025

Thanks @HrithikSampson we can call it DONE

@maryjaf maryjaf moved this to Approved by QA in Pairwise Multi Repo Backlog Jan 27, 2025
@MoeNick MoeNick moved this from Approved by QA to Merged on Production in Pairwise Multi Repo Backlog Feb 10, 2025
@MoeNick MoeNick closed this as completed Feb 11, 2025
@github-project-automation github-project-automation bot moved this from Merged on Production to Approved by QA in Pairwise Multi Repo Backlog Feb 11, 2025
@MoeNick MoeNick moved this from Approved by QA to Merged on Production in Pairwise Multi Repo Backlog Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged on Production
Development

No branches or pull requests

3 participants