Fix two instances of floating promises

Author: mmahdigh

.eslintrc.js

@@ -21,5 +21,6 @@ module.exports = {
     '@typescript-eslint/explicit-function-return-type': 'off',
     '@typescript-eslint/explicit-module-boundary-types': 'off',
     '@typescript-eslint/no-explicit-any': 'off',
+    "@typescript-eslint/no-floating-promises": ["error"]
   },
 };

src/flow/flow.controller.ts

@@ -135,6 +135,26 @@ export class FlowController {
     });
   }
 
+  // @UseGuards(AuthGuard)
+  // @ApiResponse({ status: 200, description: 'All your voting data is removed' })
+  // @Get('/insertImage')
+  // async insertImages(@Req() { userId }: AuthedReq) {
+  //   const collections = await this.prismaService.collection.findMany({
+  //     select: { id: true, name: true },
+  //   });
+
+  //   await Promise.all(
+  //     collections.map(async (collection) => {
+  //       await this.prismaService.collection.update({
+  //         where: { id: collection.id },
+  //         data: {
+  //           image: `https://wsrv.nl/?url=pairwise.cupofjoy.store/rpgf2/${collection.name}.png`,
+  //         },
+  //       });
+  //     }),
+  //   );
+  // }
+
   // @Get('/correctInvalid')
   // async checkForInvalid() {
   //   const allInvalidVotes = await this.prismaService.projectVote.findMany({

src/flow/flow.service.ts

@@ -35,7 +35,7 @@ export class FlowService {
     project2Id: number,
     pickedId: number | null,
   ) => {
-    this.validateProjectVote(project1Id, project2Id, pickedId);
+    await this.validateProjectVote(project1Id, project2Id, pickedId);
     const payload = {
       user_id: userId,
       project1_id: project1Id,
@@ -67,7 +67,7 @@ export class FlowService {
     collection2Id: number,
     pickedId: number | null,
   ) => {
-    this.validateCollectionVote(collection1Id, collection2Id, pickedId);
+    await this.validateCollectionVote(collection1Id, collection2Id, pickedId);
     const payload = {
       user_id: userId,
       collection1_id: collection1Id,
@@ -401,22 +401,25 @@ export class FlowService {
   getCollectionSubunitType = async (
     collectionId?: number,
   ): Promise<'project' | 'collection'> => {
-    const collections = await this.prismaService.collection.findFirst({
+    const collection = await this.prismaService.collection.findFirst({
       where: { parent_collection_id: collectionId },
     });
 
-    const projects = collectionId
+    const project = collectionId
       ? await this.prismaService.project.findFirst({
           where: { collection_id: collectionId },
         })
       : null;
 
-    if (collections && projects)
-      throw new Error(
+    if (collection && project)
+      throw new InternalServerErrorException(
         'A collection can not have both projects and collections as its subunits',
       );
 
-    if (collections) return 'collection';
+    if (!collection && !project)
+      throw new BadRequestException('Invalid collection id');
+
+    if (collection) return 'collection';
     return 'project';
   };
 

src/main.ts

@@ -39,4 +39,5 @@ async function bootstrap() {
 
   await app.listen(process.env.PORT || 7070, '0.0.0.0');
 }
+// eslint-disable-next-line @typescript-eslint/no-floating-promises
 bootstrap();