From c02860c28a3778e5770d2923c950f491abe599e9 Mon Sep 17 00:00:00 2001 From: Mahdi Ghajary Date: Thu, 16 Nov 2023 19:32:28 +0330 Subject: [PATCH] Simplify the edit process --- .../OverallRankingRow/EditManualModal.tsx | 6 +++--- .../RankingConfirmationModal/index.tsx | 21 +++++++++++-------- src/pages/ranking/index.tsx | 10 ++++++--- 3 files changed, 22 insertions(+), 15 deletions(-) diff --git a/src/components/Poll/Rankings/OverallRankingRow/EditManualModal.tsx b/src/components/Poll/Rankings/OverallRankingRow/EditManualModal.tsx index 55b695b..45dd297 100644 --- a/src/components/Poll/Rankings/OverallRankingRow/EditManualModal.tsx +++ b/src/components/Poll/Rankings/OverallRankingRow/EditManualModal.tsx @@ -15,18 +15,18 @@ export const EditManualModal: React.FC = ({ const handleOkClick = async () => { if (!collectionId) return await finishCollections(collectionId) - window.location.href = `/ranking?c=${collectionId}` + window.location.href = `/ranking?c=${collectionId}&edit=true` } return ( -
+

Warning

After making manual edits to a category you can't do any more pairwise rankings for that category.

-
+
{rankings && ( -
- +
+ {rankings.name} - + {(rankings?.share * 3e7).toLocaleString(undefined, { maximumFractionDigits: 2, @@ -92,10 +95,10 @@ export const RankingConfirmationModal: React.FC = () => { )} {rankings?.ranking.map((ranking) => (
{ranking.name} - + {(ranking.share * 3e7).toLocaleString(undefined, { maximumFractionDigits: 2, diff --git a/src/pages/ranking/index.tsx b/src/pages/ranking/index.tsx index a015a07..8b523d0 100644 --- a/src/pages/ranking/index.tsx +++ b/src/pages/ranking/index.tsx @@ -20,7 +20,7 @@ import { OverallRanking } from '@/components/Poll/Rankings/OverallRanking' import { OverallRankingHeader } from '@/components/Poll/Rankings/OverallRankingRow/OverallRankingHeader' import { axiosInstance } from '@/utils/axiosInstance' import { getOverallRanking } from '@/utils/poll' -import router from 'next/router' +import { useRouter } from 'next/router' export const flattenRankingData = ( input: CollectionRanking @@ -32,11 +32,15 @@ export const flattenRankingData = ( } export default function RankingPage() { + const router = useRouter() const [rankings, setRankings] = useState() const [tempRankings, setTempRankings] = useState() const [editMode, setEditMode] = useState(false) - // const [isOpen, setOpen] = useState(false) const [error, setError] = useState(false) + + useEffect(() => { + setEditMode(router.query.edit === 'true' ? true : false) + }, [router.query.edit]) const handleBack = () => { if (editMode) { @@ -97,7 +101,7 @@ export default function RankingPage() { if (!rankings || !tempRankings) { return (