Skip to content

Commit 372c39d

Browse files
committed
TODOs to support concatenating multiple PE runs
1 parent 02b2e33 commit 372c39d

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

dnanexus/input_shield/src/input_shield.py

+2
Original file line numberDiff line numberDiff line change
@@ -235,6 +235,7 @@ def main(reads1, bwa_aln_params, bwa_version, samtools_version, reads2, referenc
235235

236236

237237
reads1_files = [resolve_file(read, key) for read in reads1]
238+
#pooling of multiple single-end fastqs
238239
if len(reads1_files) > 1:
239240
pool_applet = dxpy.find_one_data_object(
240241
classname='applet', name='pool', project=dxpy.PROJECT_CONTEXT_ID,
@@ -246,6 +247,7 @@ def main(reads1, bwa_aln_params, bwa_version, samtools_version, reads2, referenc
246247
reads1_file = pool_subjob.get_output_ref("pooled")
247248
else:
248249
reads1_file = reads1_files[0]
250+
#TODO implement pooling of mulitple PE fastq pairs
249251
reads2_file = resolve_file(reads2, key)
250252
reference_tar_file = resolve_file(reference_tar, key)
251253

dnanexus/map_only.py

+2
Original file line numberDiff line numberDiff line change
@@ -317,6 +317,8 @@ def map_only(experiment, biorep_n, files, key, server, keypair, sex_specific):
317317
input_shield_stage_input.update({'reads1': [f.get('accession') for f in files]})
318318
workflows.append(build_workflow(experiment, biorep_n, input_shield_stage_input, key))
319319
elif all(isinstance(f, tuple) for f in files): #paired-end
320+
#launches separate mapping jobs for each readpair
321+
#TODO: upadte input_shield to take an array of read1/read2 PE pairs then pass that array from here
320322
for readpair in files:
321323
try:
322324
input_shield_stage_input.update(

0 commit comments

Comments
 (0)