Skip to content

Commit 91f4280

Browse files
vapierLUCI
authored andcommitted
run_tests: run all tests all the time
Using a generator w/all() causes the code to exit on the first error. We really want to see all errors all the time, so use sum() instead. Change-Id: Ib1adb8de199db9fe727d4b49c890b4d5061e9e6b Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/462901 Tested-by: Mike Frysinger <[email protected]> Commit-Queue: Mike Frysinger <[email protected]> Reviewed-by: Scott Lee <[email protected]>
1 parent 243df20 commit 91f4280

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

run_tests

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,9 @@ def main(argv):
6363
run_flake8,
6464
run_isort,
6565
)
66-
return 0 if all(not c() for c in checks) else 1
66+
# Run all the tests all the time to get full feedback. Don't exit on the
67+
# first error as that makes it more difficult to iterate in the CQ.
68+
return 1 if sum(c() for c in checks) else 0
6769

6870

6971
if __name__ == "__main__":

0 commit comments

Comments
 (0)