Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with import statuses: hash ID for Import Jobstore #4391

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Fix issue with import statuses: hash ID for Import Jobstore #4391

merged 1 commit into from
Jan 24, 2025

Conversation

dafeder
Copy link
Member

@dafeder dafeder commented Jan 24, 2025 •
edited by paul-m
Loading

Previous #4372 changed the way IDs were passed to the import jobstore, meaning records made before that change no longer display the correct status in datasetInfo or the dashboard. This restores the md5 hashing to the ID before storing.

QA Steps

  • Build a site from tag 2.19.13.
  • Import sample content
  • Check out this branch
  • drush updb
  • drush cr
  • Confirm import column shows "done" for all datasets

@dafeder dafeder marked this pull request as ready for review January 24, 2025 21:13
@paul-m paul-m changed the title Fix issue with old import statuses: hash ID for Import Jobstore Fix issue with import statuses: hash ID for Import Jobstore Jan 24, 2025
@paul-m paul-m merged commit 5a1bd68 into 2.x Jan 24, 2025
11 checks passed
@paul-m paul-m deleted the fix-import-id branch January 24, 2025 21:47
@dafeder dafeder linked an issue Jan 27, 2025 that may be closed by this pull request
Datastore Import Status Dashboard Displays Wrong Status #4387
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paul-m paul-m paul-m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Datastore Import Status Dashboard Displays Wrong Status
2 participants
@dafeder @paul-m