From faca568ed4d4fa3a1915cb7c367f5a4368d2ec4a Mon Sep 17 00:00:00 2001 From: Tim Shedor Date: Sun, 23 Feb 2025 20:44:17 -0800 Subject: [PATCH] update linter --- analysis_options.yaml | 18 +++++++++++++++++- example_supabase/lib/main.dart | 1 + .../brick_build/lib/src/serdes_generator.dart | 1 + .../brick_build_test/lib/brick_build_test.dart | 2 +- packages/brick_core/test/provider_test.dart | 2 +- .../__helpers__/demo_model_assoc_adapter.dart | 4 ++-- .../annotations/offline_first_annotation.dart | 8 ++++---- .../offline_queue/offline_request_queue.dart | 1 + .../test/offline_first/helpers/__mocks__.dart | 1 + .../offline_first/helpers/horse_adapter.dart | 4 ++-- .../offline_first/helpers/mounty_adapter.dart | 4 ++-- .../offline_first/helpers/test_domain.dart | 2 +- .../offline_first_repository_test.dart | 11 ++++++----- .../test_no_final_no_const.dart | 2 ++ .../test/graphql_offline_queue_link_test.dart | 4 ++-- .../test/test_domain/horse_adapter.dart | 6 +++--- .../test/test_domain/mounty_adapter.dart | 6 +++--- .../test/helpers/horse_adapter.dart | 4 ++-- .../test/helpers/mounty_adapter.dart | 4 ++-- .../rest_offline_queue_client_test.dart | 4 ++-- .../test/__mocks__.dart | 8 ++++---- ...ne_first_with_supabase_repository_test.dart | 2 +- packages/brick_rest/lib/src/rest_request.dart | 2 +- .../lib/memory_cache_provider.dart | 2 +- .../db/migration_commands/insert_column.dart | 2 +- .../brick_sqlite/lib/src/db/schema/schema.dart | 2 +- .../lib/src/helpers/query_sql_transformer.dart | 8 ++++---- .../test/__mocks__/demo_model_adapter.dart | 4 ++-- .../__mocks__/demo_model_assoc_adapter.dart | 4 ++-- .../lib/src/testing/supabase_mock_server.dart | 1 + 30 files changed, 74 insertions(+), 50 deletions(-) diff --git a/analysis_options.yaml b/analysis_options.yaml index 3f820439..6377f040 100644 --- a/analysis_options.yaml +++ b/analysis_options.yaml @@ -3,13 +3,14 @@ include: package:lints/recommended.yaml linter: rules: # This list is derived from the list of all available lints located at - # https://github.com/dart-lang/linter/blob/master/example/all.yaml + # https://github.com/dart-lang/sdk/blob/main/pkg/linter/example/all.yaml - always_declare_return_types # - always_put_control_body_on_new_line # - always_put_required_named_parameters_first # - always_specify_types - always_use_package_imports - annotate_overrides + - annotate_redeclares # - avoid_annotating_with_dynamic - avoid_bool_literals_in_conditional_expressions # - avoid_catches_without_on_clauses @@ -23,6 +24,7 @@ linter: - avoid_field_initializers_in_const_classes # - avoid_final_parameters - avoid_function_literals_in_foreach_calls + - avoid_futureor_void - avoid_implementing_value_types - avoid_init_to_null - avoid_js_rounded_ints @@ -70,6 +72,7 @@ linter: - directives_ordering - discarded_futures - do_not_use_environment + # - document_ignores - empty_catches - empty_constructor_bodies - empty_statements @@ -82,6 +85,7 @@ linter: - implicit_call_tearoffs - implicit_reopen - invalid_case_patterns + - invalid_runtime_check_with_js_interop_types - join_return_with_assignment # - leading_newlines_in_multiline_strings - library_annotations @@ -91,6 +95,7 @@ linter: # - lines_longer_than_80_chars - literal_only_boolean_expressions - matching_super_parameters + - missing_code_block_language_in_doc_comment - missing_whitespace_between_adjacent_strings - no_adjacent_strings_in_list - no_default_cases @@ -107,6 +112,8 @@ linter: - null_check_on_nullable_type_parameter - null_closures - omit_local_variable_types + - omit_obvious_local_variable_types + - omit_obvious_property_types - one_member_abstracts - only_throw_errors - overridden_fields @@ -164,6 +171,9 @@ linter: # - sort_constructors_first - sort_pub_dependencies - sort_unnamed_constructors_first + # - specify_nonobvious_local_variable_types + # - specify_nonobvious_property_types + # - strict_top_level_inference - test_types_in_equals - throw_in_finally - tighten_type_of_initializing_formals @@ -171,6 +181,8 @@ linter: - type_init_formals - type_literal_in_constant_pattern - unawaited_futures + - unintended_html_in_doc_comment + - unnecessary_async # - unnecessary_await_in_return - unnecessary_brace_in_string_interps - unnecessary_breaks @@ -181,6 +193,7 @@ linter: - unnecessary_lambdas - unnecessary_late - unnecessary_library_directive + - unnecessary_library_name - unnecessary_new - unnecessary_null_aware_assignments - unnecessary_null_aware_operator_on_extension_on_nullable @@ -195,8 +208,10 @@ linter: - unnecessary_string_interpolations - unnecessary_this - unnecessary_to_list_in_spreads + - unnecessary_underscores # - unreachable_from_main - unrelated_type_equality_checks + # - unsafe_variance - use_build_context_synchronously - use_colored_box - use_decorated_box @@ -216,6 +231,7 @@ linter: - use_super_parameters - use_test_throws_matchers - use_to_and_as_if_applicable + - use_truncating_division - valid_regexps - void_checks diff --git a/example_supabase/lib/main.dart b/example_supabase/lib/main.dart index 02ef2c03..700b007b 100644 --- a/example_supabase/lib/main.dart +++ b/example_supabase/lib/main.dart @@ -48,6 +48,7 @@ class MyHomePage extends StatelessWidget { body: Container( padding: const EdgeInsets.all(20), child: FutureBuilder( + // necesary future // ignore: discarded_futures future: Repository().get(), builder: (context, AsyncSnapshot> pizzaList) { diff --git a/packages/brick_build/lib/src/serdes_generator.dart b/packages/brick_build/lib/src/serdes_generator.dart index 731aeaba..9ac50deb 100644 --- a/packages/brick_build/lib/src/serdes_generator.dart +++ b/packages/brick_build/lib/src/serdes_generator.dart @@ -84,6 +84,7 @@ abstract class SerdesGenerator Function(String filename); /// Thunks a reader generator that assumes the filename is prefixed `test_` /// and suffixed `.dart` and nested in [folder] in the `test` folder. LibraryGenerator generateLibraryForFolder(String folder) { - return (String filename) async { + return (String filename) { return _libraryForFolder(folder, filename); }; } diff --git a/packages/brick_core/test/provider_test.dart b/packages/brick_core/test/provider_test.dart index aac1af8f..aadf1495 100644 --- a/packages/brick_core/test/provider_test.dart +++ b/packages/brick_core/test/provider_test.dart @@ -13,7 +13,7 @@ void main() { expect(res.first.name, 'Thomas'); }); - test('#upsert', () async { + test('#upsert', () { final res = provider.upsert(DemoModel('Thomas')); expect(res, isTrue); }); diff --git a/packages/brick_graphql/test/__helpers__/demo_model_assoc_adapter.dart b/packages/brick_graphql/test/__helpers__/demo_model_assoc_adapter.dart index b4d1c681..df942e1b 100644 --- a/packages/brick_graphql/test/__helpers__/demo_model_assoc_adapter.dart +++ b/packages/brick_graphql/test/__helpers__/demo_model_assoc_adapter.dart @@ -29,7 +29,7 @@ class DemoModelAssocAdapter extends GraphqlAdapter { DemoModelAssocAdapter(); @override - final Map fieldsToGraphqlRuntimeDefinition = { + final fieldsToGraphqlRuntimeDefinition = { 'primaryKey': const RuntimeGraphqlDefinition( documentNodeName: 'primaryKey', type: int, @@ -73,7 +73,7 @@ class DemoModelAssocWithSubfieldsAdapter extends GraphqlAdapter final queryOperationTransformer = _DemoModelAssocTransformer.new; @override - final Map fieldsToGraphqlRuntimeDefinition = { + final fieldsToGraphqlRuntimeDefinition = { 'primaryKey': const RuntimeGraphqlDefinition( documentNodeName: '_brick_id', type: int, diff --git a/packages/brick_offline_first/lib/src/annotations/offline_first_annotation.dart b/packages/brick_offline_first/lib/src/annotations/offline_first_annotation.dart index 859f119f..5c75450c 100644 --- a/packages/brick_offline_first/lib/src/annotations/offline_first_annotation.dart +++ b/packages/brick_offline_first/lib/src/annotations/offline_first_annotation.dart @@ -8,7 +8,7 @@ class OfflineFirst { /// /// For example, given the API: `{"classField" : true, "assoc": { "id": 12345 }}` and the `where` /// configuration `{'id' : "data['assoc']['id']"}`, a REST adapter would generate - /// ``` + /// ```dart /// await repository?.getAssociation( /// Query(where: [Where.exact('id', data['assoc']['id])], limit: 1) /// ) @@ -17,7 +17,7 @@ class OfflineFirst { /// When `false`, the output would generate assuming the full payload is present. Given the API /// `{"classField" : true, "assoc": { "id": 12345, "name": "class name" }}`, a REST adapter would /// generate - /// ``` + /// ```dart /// await AssociationAdapter().fromRest(data['assoc'], provider: provider, repository: repository)) /// ``` final bool applyToRemoteDeserialization; @@ -27,13 +27,13 @@ class OfflineFirst { /// If the field type is an `Iterable`, the map requires the field value to be an `Iterable`. /// /// For example, given an API: `{"classField" : true, "assoc": { "id": 12345 }}`, - /// ``` + /// ```dart /// @OfflineFirst(where: {'id' : "data['assoc']['id']"}) /// final Assoc assoc; /// ``` /// /// Or given a list: `{"classField" : true, "assoc": { "ids": [12345, 6789] }}` - /// ``` + /// ```dart /// @OfflineFirst(where: {'id' : "data['assoc']['ids']"}) /// final List assocs; /// ``` diff --git a/packages/brick_offline_first/lib/src/offline_queue/offline_request_queue.dart b/packages/brick_offline_first/lib/src/offline_queue/offline_request_queue.dart index 19a44ef6..1bdde319 100644 --- a/packages/brick_offline_first/lib/src/offline_queue/offline_request_queue.dart +++ b/packages/brick_offline_first/lib/src/offline_queue/offline_request_queue.dart @@ -15,6 +15,7 @@ abstract class OfflineRequestQueue { /// This mutex ensures that concurrent writes to the DB will /// not occur as the Timer runs in sub routines or isolates + // ignore: omit_obvious_property_types bool _processingInBackground = false; /// How often requests are reattempted diff --git a/packages/brick_offline_first/test/offline_first/helpers/__mocks__.dart b/packages/brick_offline_first/test/offline_first/helpers/__mocks__.dart index 05cb1528..6410f1c3 100644 --- a/packages/brick_offline_first/test/offline_first/helpers/__mocks__.dart +++ b/packages/brick_offline_first/test/offline_first/helpers/__mocks__.dart @@ -49,6 +49,7 @@ class TestRepository extends OfflineFirstWithTestRepository { static late TestRepository? _singleton; /// A hack to similuate a failure in the remote provider + // ignore: omit_obvious_property_types static bool throwOnNextRemoteMutation = false; factory TestRepository() => _singleton!; diff --git a/packages/brick_offline_first/test/offline_first/helpers/horse_adapter.dart b/packages/brick_offline_first/test/offline_first/helpers/horse_adapter.dart index cb5f7fc5..214bec40 100644 --- a/packages/brick_offline_first/test/offline_first/helpers/horse_adapter.dart +++ b/packages/brick_offline_first/test/offline_first/helpers/horse_adapter.dart @@ -70,7 +70,7 @@ class HorseAdapter extends OfflineFirstWithTestAdapter { HorseAdapter(); @override - final Map fieldsToSqliteColumns = { + final fieldsToSqliteColumns = { 'primaryKey': const RuntimeSqliteColumnDefinition( columnName: '_brick_id', type: int, @@ -90,7 +90,7 @@ class HorseAdapter extends OfflineFirstWithTestAdapter { Future primaryKeyByUniqueColumns(Horse instance, DatabaseExecutor executor) async => instance.primaryKey; @override - final String tableName = 'Horse'; + final tableName = 'Horse'; @override Future afterSave( Horse instance, { diff --git a/packages/brick_offline_first/test/offline_first/helpers/mounty_adapter.dart b/packages/brick_offline_first/test/offline_first/helpers/mounty_adapter.dart index fba30032..7ba48a15 100644 --- a/packages/brick_offline_first/test/offline_first/helpers/mounty_adapter.dart +++ b/packages/brick_offline_first/test/offline_first/helpers/mounty_adapter.dart @@ -38,7 +38,7 @@ class MountyAdapter extends OfflineFirstWithTestAdapter { MountyAdapter(); @override - final Map fieldsToSqliteColumns = { + final fieldsToSqliteColumns = { 'primaryKey': const RuntimeSqliteColumnDefinition( columnName: '_brick_id', type: int, @@ -52,7 +52,7 @@ class MountyAdapter extends OfflineFirstWithTestAdapter { Future primaryKeyByUniqueColumns(Mounty instance, DatabaseExecutor executor) async => instance.primaryKey; @override - final String tableName = 'Mounty'; + final tableName = 'Mounty'; @override Future fromTest( diff --git a/packages/brick_offline_first/test/offline_first/helpers/test_domain.dart b/packages/brick_offline_first/test/offline_first/helpers/test_domain.dart index 47c18f12..a07a9280 100644 --- a/packages/brick_offline_first/test/offline_first/helpers/test_domain.dart +++ b/packages/brick_offline_first/test/offline_first/helpers/test_domain.dart @@ -11,7 +11,7 @@ import 'package:brick_sqlite/memory_cache_provider.dart'; import '__mocks__.dart'; class TestProvider extends Provider { - List methodsCalled = []; + final methodsCalled = []; @override final TestModelDictionary modelDictionary; diff --git a/packages/brick_offline_first/test/offline_first/offline_first_repository_test.dart b/packages/brick_offline_first/test/offline_first/offline_first_repository_test.dart index 7fbb7809..a24a45b7 100644 --- a/packages/brick_offline_first/test/offline_first/offline_first_repository_test.dart +++ b/packages/brick_offline_first/test/offline_first/offline_first_repository_test.dart @@ -24,7 +24,7 @@ void main() { (TestRepository().remoteProvider as TestProvider).methodsCalled.clear(); }); - test('#applyPolicyToQuery', () async { + test('#applyPolicyToQuery', () { const policy = OfflineFirstGetPolicy.localOnly; final query = TestRepository().applyPolicyToQuery(const Query(), get: policy); expect(query?.action?.index, policy.index); @@ -176,7 +176,7 @@ void main() { expect(results.primaryKey, greaterThanOrEqualTo(1)); }); - test('OfflineFirstUpsertPolicy.requireRemote', () async { + test('OfflineFirstUpsertPolicy.requireRemote', () { final instance = Mounty(name: 'SqliteName'); TestRepository.throwOnNextRemoteMutation = true; expect( @@ -197,7 +197,7 @@ void main() { }); group('#subscribe', () { - test('adds controller and query to #subscriptions', () async { + test('adds controller and query to #subscriptions', () { expect(TestRepository().subscriptions, hasLength(0)); final query = Query.where('name', 'Thomas'); TestRepository().subscribe(query: query); @@ -207,7 +207,7 @@ void main() { expect(TestRepository().subscriptions[Mounty]!.entries.first.value, isNotNull); }); - test('subscription succeeds when policy is non-default .awaitRemote', () async { + test('subscription succeeds when policy is non-default .awaitRemote', () { expect(TestRepository().subscriptions, hasLength(0)); final query = Query.where('name', 'Thomas'); TestRepository().subscribe(policy: OfflineFirstGetPolicy.awaitRemote, query: query); @@ -215,7 +215,7 @@ void main() { expect(TestRepository().subscriptions[Mounty], hasLength(1)); }); - test('adds controller and null query to #subscriptions', () async { + test('adds controller and null query to #subscriptions', () { expect(TestRepository().subscriptions, hasLength(0)); TestRepository().subscribe(); expect(TestRepository().subscriptions, hasLength(1)); @@ -239,6 +239,7 @@ void main() { subscription.pause(); expect(TestRepository().subscriptions, hasLength(1)); expect(TestRepository().subscriptions[Mounty]!.entries.first.value.isPaused, isTrue); + await subscription.cancel(); }); test('stores fetched data', () async { diff --git a/packages/brick_offline_first_build/test/offline_first_generator/test_no_final_no_const.dart b/packages/brick_offline_first_build/test/offline_first_generator/test_no_final_no_const.dart index 79f726ad..2eeaee49 100644 --- a/packages/brick_offline_first_build/test/offline_first_generator/test_no_final_no_const.dart +++ b/packages/brick_offline_first_build/test/offline_first_generator/test_no_final_no_const.dart @@ -1,3 +1,5 @@ +// ignore_for_file: omit_obvious_property_types + import 'package:brick_offline_first_with_rest/brick_offline_first_with_rest.dart'; const output = r''' diff --git a/packages/brick_offline_first_with_graphql/test/graphql_offline_queue_link_test.dart b/packages/brick_offline_first_with_graphql/test/graphql_offline_queue_link_test.dart index 0c88fde3..ee55fdf7 100644 --- a/packages/brick_offline_first_with_graphql/test/graphql_offline_queue_link_test.dart +++ b/packages/brick_offline_first_with_graphql/test/graphql_offline_queue_link_test.dart @@ -174,7 +174,7 @@ void main() { expect(capturedRequest, mutationRequest); }); - test('callback is not triggered when request succeeds', () async { + test('callback is not triggered when request succeeds', () { Request? capturedRequest; final mockLink = MockLink(); @@ -228,7 +228,7 @@ void main() { expect(capturedonException.toString(), contains('Test failure')); }); - test('callback is not triggered on successful response', () async { + test('callback is not triggered on successful response', () { Request? capturedRequest; Object? capturedException; diff --git a/packages/brick_offline_first_with_graphql/test/test_domain/horse_adapter.dart b/packages/brick_offline_first_with_graphql/test/test_domain/horse_adapter.dart index 31a127cc..de417340 100644 --- a/packages/brick_offline_first_with_graphql/test/test_domain/horse_adapter.dart +++ b/packages/brick_offline_first_with_graphql/test/test_domain/horse_adapter.dart @@ -121,7 +121,7 @@ class HorseAdapter extends OfflineFirstWithGraphqlAdapter { HorseAdapter(); @override - final Map fieldsToGraphqlRuntimeDefinition = { + final fieldsToGraphqlRuntimeDefinition = { 'primaryKey': const RuntimeGraphqlDefinition( documentNodeName: '_brick_id', type: int, @@ -139,7 +139,7 @@ class HorseAdapter extends OfflineFirstWithGraphqlAdapter { }; @override - final Map fieldsToSqliteColumns = { + final fieldsToSqliteColumns = { 'primaryKey': const RuntimeSqliteColumnDefinition( columnName: '_brick_id', type: int, @@ -159,7 +159,7 @@ class HorseAdapter extends OfflineFirstWithGraphqlAdapter { Future primaryKeyByUniqueColumns(Horse instance, DatabaseExecutor executor) async => instance.primaryKey; @override - final String tableName = 'Horse'; + final tableName = 'Horse'; @override Future afterSave( Horse instance, { diff --git a/packages/brick_offline_first_with_graphql/test/test_domain/mounty_adapter.dart b/packages/brick_offline_first_with_graphql/test/test_domain/mounty_adapter.dart index dec9ac82..7205a21c 100644 --- a/packages/brick_offline_first_with_graphql/test/test_domain/mounty_adapter.dart +++ b/packages/brick_offline_first_with_graphql/test/test_domain/mounty_adapter.dart @@ -87,7 +87,7 @@ class MountyAdapter extends OfflineFirstWithGraphqlAdapter { MountyAdapter(); @override - final Map fieldsToSqliteColumns = { + final fieldsToSqliteColumns = { 'primaryKey': const RuntimeSqliteColumnDefinition( columnName: '_brick_id', type: int, @@ -99,7 +99,7 @@ class MountyAdapter extends OfflineFirstWithGraphqlAdapter { }; @override - final Map fieldsToGraphqlRuntimeDefinition = { + final fieldsToGraphqlRuntimeDefinition = { 'name': const RuntimeGraphqlDefinition( documentNodeName: 'name', type: String, @@ -109,7 +109,7 @@ class MountyAdapter extends OfflineFirstWithGraphqlAdapter { Future primaryKeyByUniqueColumns(Mounty instance, DatabaseExecutor executor) async => instance.primaryKey; @override - final String tableName = 'Mounty'; + final tableName = 'Mounty'; @override Future fromGraphql( diff --git a/packages/brick_offline_first_with_rest/test/helpers/horse_adapter.dart b/packages/brick_offline_first_with_rest/test/helpers/horse_adapter.dart index b94b112e..0abdf33d 100644 --- a/packages/brick_offline_first_with_rest/test/helpers/horse_adapter.dart +++ b/packages/brick_offline_first_with_rest/test/helpers/horse_adapter.dart @@ -70,7 +70,7 @@ class HorseAdapter extends OfflineFirstWithRestAdapter { HorseAdapter(); @override - final Map fieldsToSqliteColumns = { + final fieldsToSqliteColumns = { 'primaryKey': const RuntimeSqliteColumnDefinition( columnName: '_brick_id', type: int, @@ -90,7 +90,7 @@ class HorseAdapter extends OfflineFirstWithRestAdapter { Future primaryKeyByUniqueColumns(Horse instance, DatabaseExecutor executor) async => instance.primaryKey; @override - final String tableName = 'Horse'; + final tableName = 'Horse'; @override Future afterSave( Horse instance, { diff --git a/packages/brick_offline_first_with_rest/test/helpers/mounty_adapter.dart b/packages/brick_offline_first_with_rest/test/helpers/mounty_adapter.dart index 57d6f611..9e505bb3 100644 --- a/packages/brick_offline_first_with_rest/test/helpers/mounty_adapter.dart +++ b/packages/brick_offline_first_with_rest/test/helpers/mounty_adapter.dart @@ -41,7 +41,7 @@ class MountyAdapter extends OfflineFirstWithRestAdapter { final restRequest = MountyRequestTransformer.new; @override - final Map fieldsToSqliteColumns = { + final fieldsToSqliteColumns = { 'primaryKey': const RuntimeSqliteColumnDefinition( columnName: '_brick_id', type: int, @@ -55,7 +55,7 @@ class MountyAdapter extends OfflineFirstWithRestAdapter { Future primaryKeyByUniqueColumns(Mounty instance, DatabaseExecutor executor) async => instance.primaryKey; @override - final String tableName = 'Mounty'; + final tableName = 'Mounty'; @override Future fromRest( diff --git a/packages/brick_offline_first_with_rest/test/offline_queue/rest_offline_queue_client_test.dart b/packages/brick_offline_first_with_rest/test/offline_queue/rest_offline_queue_client_test.dart index bca42c40..14d8fbad 100644 --- a/packages/brick_offline_first_with_rest/test/offline_queue/rest_offline_queue_client_test.dart +++ b/packages/brick_offline_first_with_rest/test/offline_queue/rest_offline_queue_client_test.dart @@ -129,7 +129,7 @@ void main() { group('request is not deleted', () { test('after an unsuccessful response and is created', () async { - final inner = MockClient((req) async { + final inner = MockClient((req) { throw StateError('server not found'); }); @@ -237,7 +237,7 @@ void main() { http.Request? capturedRequest; Object? capturedException; - final inner = MockClient((req) async { + final inner = MockClient((req) { throw const SocketException('test error'); }); diff --git a/packages/brick_offline_first_with_supabase/test/__mocks__.dart b/packages/brick_offline_first_with_supabase/test/__mocks__.dart index 97e63afc..a0c196bb 100644 --- a/packages/brick_offline_first_with_supabase/test/__mocks__.dart +++ b/packages/brick_offline_first_with_supabase/test/__mocks__.dart @@ -179,7 +179,7 @@ class PizzaAdapter extends OfflineFirstWithSupabaseAdapter { @override final uniqueFields = {}; @override - final Map fieldsToSqliteColumns = { + final fieldsToSqliteColumns = { 'primaryKey': const RuntimeSqliteColumnDefinition( columnName: '_brick_id', type: int, @@ -215,7 +215,7 @@ class PizzaAdapter extends OfflineFirstWithSupabaseAdapter { } @override - final String tableName = 'Pizza'; + final tableName = 'Pizza'; @override Future fromSupabase( @@ -352,7 +352,7 @@ class CustomerAdapter extends OfflineFirstWithSupabaseAdapter { @override final uniqueFields = {}; @override - final Map fieldsToSqliteColumns = { + final fieldsToSqliteColumns = { 'primaryKey': const RuntimeSqliteColumnDefinition( columnName: '_brick_id', type: int, @@ -393,7 +393,7 @@ class CustomerAdapter extends OfflineFirstWithSupabaseAdapter { } @override - final String tableName = 'Customer'; + final tableName = 'Customer'; @override Future afterSave( Customer instance, { diff --git a/packages/brick_offline_first_with_supabase/test/offline_first_with_supabase_repository_test.dart b/packages/brick_offline_first_with_supabase/test/offline_first_with_supabase_repository_test.dart index 24405079..2db9f11e 100644 --- a/packages/brick_offline_first_with_supabase/test/offline_first_with_supabase_repository_test.dart +++ b/packages/brick_offline_first_with_supabase/test/offline_first_with_supabase_repository_test.dart @@ -48,7 +48,7 @@ class TestRepository extends OfflineFirstWithSupabaseRepository { } } -void main() async { +void main() { sqfliteFfiInit(); final mock = SupabaseMockServer(modelDictionary: supabaseModelDictionary); diff --git a/packages/brick_rest/lib/src/rest_request.dart b/packages/brick_rest/lib/src/rest_request.dart index 0921210a..4db4a4bf 100644 --- a/packages/brick_rest/lib/src/rest_request.dart +++ b/packages/brick_rest/lib/src/rest_request.dart @@ -21,7 +21,7 @@ class RestRequest { /// /// **Example** /// Given the payload: - /// ``` + /// ```dart /// { "user" : {"id" : 1, "name" : "Thomas" }} /// ``` /// The [topLevelKey] would be `"user"`. diff --git a/packages/brick_sqlite/lib/memory_cache_provider.dart b/packages/brick_sqlite/lib/memory_cache_provider.dart index 944bb881..3a2b314f 100644 --- a/packages/brick_sqlite/lib/memory_cache_provider.dart +++ b/packages/brick_sqlite/lib/memory_cache_provider.dart @@ -12,7 +12,7 @@ import 'package:meta/meta.dart'; class MemoryCacheProvider extends Provider { /// @protected - final Logger logger = Logger('MemoryCacheProvider'); + final logger = Logger('MemoryCacheProvider'); /// The only model classes this instance should track. /// As storing objects in memory can be costly elsewhere in the app, models should be diff --git a/packages/brick_sqlite/lib/src/db/migration_commands/insert_column.dart b/packages/brick_sqlite/lib/src/db/migration_commands/insert_column.dart index b90855e5..383fd208 100644 --- a/packages/brick_sqlite/lib/src/db/migration_commands/insert_column.dart +++ b/packages/brick_sqlite/lib/src/db/migration_commands/insert_column.dart @@ -95,7 +95,7 @@ class InsertColumn extends MigrationCommand { MigrationCommand get down => DropColumn(name, onTable: onTable); /// Defaults - static const InsertColumn defaults = InsertColumn( + static const defaults = InsertColumn( 'PLACEHOLDER', Column.varchar, onTable: 'PLACEHOLDER', diff --git a/packages/brick_sqlite/lib/src/db/schema/schema.dart b/packages/brick_sqlite/lib/src/db/schema/schema.dart index 6fb85e98..bb113d5d 100644 --- a/packages/brick_sqlite/lib/src/db/schema/schema.dart +++ b/packages/brick_sqlite/lib/src/db/schema/schema.dart @@ -36,7 +36,7 @@ class Schema { /// Generator used to produce this schema; not intended for public use // ignore: constant_identifier_names - static const int GENERATOR_VERSION = 1; + static const GENERATOR_VERSION = 1; /// @visibleForTesting diff --git a/packages/brick_sqlite/lib/src/helpers/query_sql_transformer.dart b/packages/brick_sqlite/lib/src/helpers/query_sql_transformer.dart index 25173190..45751ddf 100644 --- a/packages/brick_sqlite/lib/src/helpers/query_sql_transformer.dart +++ b/packages/brick_sqlite/lib/src/helpers/query_sql_transformer.dart @@ -24,10 +24,10 @@ class QuerySqlTransformer<_Model extends SqliteModel> { /// All other [SqliteAdapter]s and [SqliteModel]s known to the provider final SqliteModelDictionary modelDictionary; - final List _statement = []; - final List _where = []; - final Set _innerJoins = {}; - final List _values = []; + final _statement = []; + final _where = []; + final _innerJoins = {}; + final _values = []; /// Must-haves for the [statement], mainly used to build clauses final Query? query; diff --git a/packages/brick_sqlite/test/__mocks__/demo_model_adapter.dart b/packages/brick_sqlite/test/__mocks__/demo_model_adapter.dart index 719a75dd..ffb4e8be 100644 --- a/packages/brick_sqlite/test/__mocks__/demo_model_adapter.dart +++ b/packages/brick_sqlite/test/__mocks__/demo_model_adapter.dart @@ -73,7 +73,7 @@ class DemoModelAdapter extends SqliteAdapter { DemoModelAdapter(); @override - final Map fieldsToSqliteColumns = { + final fieldsToSqliteColumns = { 'primaryKey': const RuntimeSqliteColumnDefinition( columnName: '_brick_id', type: int, @@ -124,7 +124,7 @@ class DemoModelAdapter extends SqliteAdapter { instance.primaryKey; @override - final String tableName = 'DemoModel'; + final tableName = 'DemoModel'; @override Future afterSave( DemoModel instance, { diff --git a/packages/brick_sqlite/test/__mocks__/demo_model_assoc_adapter.dart b/packages/brick_sqlite/test/__mocks__/demo_model_assoc_adapter.dart index aba53fd7..b9c1f1dc 100644 --- a/packages/brick_sqlite/test/__mocks__/demo_model_assoc_adapter.dart +++ b/packages/brick_sqlite/test/__mocks__/demo_model_assoc_adapter.dart @@ -26,7 +26,7 @@ class DemoModelAssocAdapter extends SqliteAdapter { DemoModelAssocAdapter(); @override - final Map fieldsToSqliteColumns = { + final fieldsToSqliteColumns = { 'primaryKey': const RuntimeSqliteColumnDefinition( columnName: '_brick_id', type: int, @@ -76,7 +76,7 @@ class DemoModelAssocAdapter extends SqliteAdapter { instance.primaryKey; @override - final String tableName = 'DemoModelAssoc'; + final tableName = 'DemoModelAssoc'; @override Future fromSqlite( diff --git a/packages/brick_supabase/lib/src/testing/supabase_mock_server.dart b/packages/brick_supabase/lib/src/testing/supabase_mock_server.dart index ebef13bf..c78cd492 100644 --- a/packages/brick_supabase/lib/src/testing/supabase_mock_server.dart +++ b/packages/brick_supabase/lib/src/testing/supabase_mock_server.dart @@ -20,6 +20,7 @@ class SupabaseMockServer { late SupabaseClient client; /// If a stream listener has been registered + // ignore: omit_obvious_property_types bool hasListener = false; /// The active stream listener