Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apparently there is a type defaulting logic implemented in swagger tools that is not specified #131

Open
loewenstein opened this issue Oct 24, 2017 · 1 comment

Comments

@loewenstein
Copy link

Cannot parse https://raw.githubusercontent.com/kubernetes/kubernetes/master/api/openapi-spec/swagger.json because it does not contain type attributes for definitions.

swagger-cli does successfully validate that same OpenAPI spec document though.

I have created an issue on the spec repo that this should be specified so that all tools are aligned. OAI/OpenAPI-Specification#1388

Maybe we can come to correctly parsing swagger documents created with swagger tools even without waiting for the spec to explicitly state the defaulting logic.

@loewenstein
Copy link
Author

According to the discussions on OAI/OpenAPI-Specification#1388 we should probably allow definitions not to specify a 'type' attribute.

swamp-agr pushed a commit that referenced this issue Aug 22, 2018
According to OpenAPI as it mentioned in #131, "type" might not be specified. It is implemented currently in Kubernetes. Thus, interface is changing with this fix. CHANGELOG should be also updated.
phadej pushed a commit that referenced this issue Apr 25, 2019
According to OpenAPI as it mentioned in #131, "type" might not be specified. It is implemented currently in Kubernetes. Thus, interface is changing with this fix. CHANGELOG should be also updated.
phadej pushed a commit that referenced this issue May 17, 2019
According to OpenAPI as it mentioned in #131, "type" might not be specified. It is implemented currently in Kubernetes. Thus, interface is changing with this fix. CHANGELOG should be also updated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant