Skip to content

Commit 1ae2c87

Browse files
authored
Avoid unnecessary string refcounting in ext/date (php#17890)
1 parent d95b9d6 commit 1ae2c87

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

ext/date/php_date.c

+3-2
Original file line numberDiff line numberDiff line change
@@ -4682,9 +4682,10 @@ static void php_date_interval_initialize_from_hash(zval **return_value, php_inte
46824682
if (z_arg && Z_TYPE_P(z_arg) == IS_FALSE) { \
46834683
(*intobj)->diff->member = TIMELIB_UNSET; \
46844684
} else if (z_arg && Z_TYPE_P(z_arg) <= IS_STRING) { \
4685-
zend_string *str = zval_get_string(z_arg); \
4685+
zend_string *tmp_str; \
4686+
zend_string *str = zval_get_tmp_string(z_arg, &tmp_str); \
46864687
DATE_A64I((*intobj)->diff->member, ZSTR_VAL(str)); \
4687-
zend_string_release(str); \
4688+
zend_tmp_string_release(tmp_str); \
46884689
} else { \
46894690
(*intobj)->diff->member = -1LL; \
46904691
} \

0 commit comments

Comments
 (0)