Changing accounts resets to main tab fix (#2114)

ismetanin · rnystrom · commit f619a256bc75 · 2018-08-13T21:53:45.000-04:00
* Fix issue changing accounts resets to main tab

* Pull request review code fix
diff --git a/Classes/Systems/RootNavigationManager.swift b/Classes/Systems/RootNavigationManager.swift
@@ -54,6 +54,8 @@ final class RootNavigationManager: GitHubSessionListener {
         } else {
             block()
         }
+
+        self.tabBarController?.selectedIndex = 0
     }
 
     public func resetRootViewController(userSession: GitHubUserSession?) {
@@ -77,8 +79,6 @@ final class RootNavigationManager: GitHubSessionListener {
             newBookmarksRootViewController(client: client),
             settingsRootViewController ?? UIViewController() // simply satisfying compiler
         ]
-
-        tabBarController?.selectedIndex = 0
     }
 
     public func pushLoginViewController(nav: UINavigationController) {

Original file line number	Diff line number	Diff line change
`@@ -54,6 +54,8 @@ final class RootNavigationManager: GitHubSessionListener {`
`54`	`54`	`} else {`
`55`	`55`	`block()`
`56`	`56`	`}`
	`57`	`+`
	`58`	`+ self.tabBarController?.selectedIndex = 0`
`57`	`59`	`}`
`58`	`60`
`59`	`61`	`public func resetRootViewController(userSession: GitHubUserSession?) {`
`@@ -77,8 +79,6 @@ final class RootNavigationManager: GitHubSessionListener {`
`77`	`79`	`newBookmarksRootViewController(client: client),`
`78`	`80`	`settingsRootViewController ?? UIViewController() // simply satisfying compiler`
`79`	`81`	`]`
`80`		`-`
`81`		`- tabBarController?.selectedIndex = 0`
`82`	`82`	`}`
`83`	`83`
`84`	`84`	`public func pushLoginViewController(nav: UINavigationController) {`