Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo pull request #1

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Demo pull request #1

wants to merge 3 commits into from

Conversation

smith-kyle
Copy link
Member

@smith-kyle smith-kyle commented Oct 14, 2023

No description provided.

@gitnotebooks
Copy link

gitnotebooks bot commented Oct 14, 2023

Found 2 changed notebooks. Review the changes at https://gitnotebooks.com/GitNotebooks/demo/pull/1

Copy link
Member Author

We can see dataframe diffs??

Respond and view the context here.

Copy link
Member Author

Inline comments on the left and right!

Respond and view the context here.

Copy link
Member Author

Plots are rendered too!

Respond and view the context here.

Copy link
Member Author

Markdown rendering ftw!

Respond and view the context here.

Copy link
Member Author

Comments are marked Outdated when the line changes after the comment was posted

Respond and view the context here.

@smith-kyle smith-kyle force-pushed the my-branch branch 4 times, most recently from ad9610f to 211f47a Compare January 17, 2024 20:33
Copy link

Nice.

Respond and view the context here.

Copy link

Test comment

Respond and view the context here.

Copy link

Code comment.

Respond and view the context here.

Copy link

Really?

Respond and view the context here.

Copy link
Member Author

Commented on notebook pandas-example.ipynb Cell 12 Line 5

## Ufuncs: Operations Between DataFrame and Series

When performing operations between a ``DataFrame`` and a ``Series``, the index and column alignment is similarly maintained.
Operations between a ``DataFrame`` and a ``Series`` are similar to operations between a two-dimensional and one-dimensional NumPy array.
Consider one common operation, where we find the difference of a two-dimensional array and one of its rows:

Comment on markdown cells!

Respond and view the context here.

Copy link

@Jujuben3885 Jujuben3885 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello and hi

@@ -16,7 +16,7 @@
},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented on notebook sklearn-example.ipynb Cell 5 From line 2 to 3

iris['PCA2'] = X_2D[:, 1]
sns.lmplot(x="PCA1", y="PCA2", hue='species', data=iris, fit_reg=False);

Comments on the left and right!

Respond and view the context here.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I add comments

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like better separation among the classes now. Have you tried something like a kernelPCA?

@@ -11,24 +11,24 @@
"cell_type": "markdown",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented on notebook pandas-example.ipynb Cell 12 Line 1

## Ufuncs: Operations Between DataFrame and Series with a changed header

"start a review" button didn't work for me - Android chrome

Copy link

@asah asah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test

Copy link

@asah asah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I submitted a review but the review charges button is still available... So I'm submitting another... ?

@@ -11,24 +11,24 @@
"cell_type": "markdown",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented on notebook pandas-example.ipynb Cell 1 Line 1

# Operating on Data in Pandas

Commenting on the header Operating on Data in Pandas

@@ -11,24 +11,24 @@
"cell_type": "markdown",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented on notebook pandas-example.ipynb Cell 1 Line 1

# Operating on Data in Pandas

Woo!

@@ -11,24 +11,24 @@
"cell_type": "markdown",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented on notebook pandas-example.ipynb Cell 11 Line 18

# Large cells? No problem. Cells are collapsed to showcase the diff
# Large cells? No problem. Cells are collapsed to showcase the diff
# Large cells? No problem. Cells are collapsed to showcase the diff
# Large cells? No problem. Cells are collapsed to showcase the diff
# Large cells? No problem. Cells are collapsed to showcase the diff
# Large cells? No problem. Cells are collapsed to showcase the diff

fill = A.stack().mean()

Comment Test

Copy link

@user-demo-user user-demo-user left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -11,24 +11,24 @@
"cell_type": "markdown",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented on notebook pandas-example.ipynb Cell 5 Line 1

Any item for which one or the other does not have an entry is marked with ``NaN``, or "Not a Number," which is how Pandas marks missing data (see further discussion of missing data in [Handling Missing Data](03.04-Missing-Values.ipynb)).

Leaving a diff comment

Copy link

@user-demo-user user-demo-user left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!!!

@@ -11,24 +11,24 @@
"cell_type": "markdown",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented on notebook pandas-example.ipynb Cell 3 Line 5

One of the essential pieces of NumPy is the ability to perform quick element-wise operations, both with basic arithmetic (addition, subtraction, multiplication, etc.) and with more sophisticated operations (trigonometric functions, exponential and logarithmic functions, etc.).
Pandas inherits much of this functionality from NumPy, and the ufuncs that we introduced in [Computation on NumPy Arrays: Universal Functions](https://gitnotebooks.com/blog) are key to this.

Pandas includes a couple useful twists, however: for unary operations like negation and trigonometric functions, these ufuncs will *preserve index and column labels* in the output, and for binary operations such as addition and multiplication, Pandas will automatically *align indices* when passing the objects to the ufunc.
This means that keeping the context of data and combining data from different sources–both potentially error-prone tasks with raw NumPy arrays–become essentially foolproof ones with Pandas.

Leaving a comment here!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolving this comment!

Copy link

@user-demo-user user-demo-user left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -11,24 +11,24 @@
"cell_type": "markdown",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented on notebook pandas-example.ipynb Cell 8 Line 1

A.subtract(B, fill_value=0)

Leaving a comment!

@@ -11,24 +11,24 @@
"cell_type": "markdown",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented on notebook pandas-example.ipynb Cell 9 Line 1

Observe that the indices align accurately regardless of their sequence in the two objects, and the result's indices are organized in ascending order.

Adding another comment

Copy link

@user-demo-user user-demo-user left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs 2 changes

@@ -11,24 +11,24 @@
"cell_type": "markdown",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented on notebook pandas-example.ipynb Cell 8 Line 1

A.subtract(B, fill_value=0)

Leaving a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes needed!

@@ -11,24 +11,24 @@
"cell_type": "markdown",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented on notebook pandas-example.ipynb Cell 9 Line 1

Notice that indices are aligned correctly irrespective of their order in the two objects, and indices in the result are sorted.

Commenting on other side

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes needed!

Copy link

@user-demo-user user-demo-user left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -11,24 +11,24 @@
"cell_type": "markdown",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented on notebook pandas-example.ipynb Cell 3 Line 4

One of the essential pieces of NumPy is the ability to perform quick element-wise operations, both with basic arithmetic (addition, subtraction, multiplication, etc.) and with more sophisticated operations (trigonometric functions, exponential and logarithmic functions, etc.).
Pandas inherits much of this functionality from NumPy, and the ufuncs that we introduced in [Computation on NumPy Arrays: Universal Functions](https://gitnotebooks.com/blog) are key to this.

Pandas includes a couple useful twists, however: for unary operations like negation and trigonometric functions, these ufuncs will *preserve index and column labels* in the output, and for binary operations such as addition and multiplication, Pandas will automatically *align indices* when passing the objects to the ufunc.

comment

@@ -11,24 +11,24 @@
"cell_type": "markdown",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented on notebook pandas-example.ipynb Cell 5 Line 1

Any item for which one or the other does not have an entry is marked with ``NaN``, or "Not a Number," which is how Pandas marks missing data (see further discussion of missing data in [Handling Missing Data](03.04-Missing-Values.ipynb)).

Can I suggest the change here ? +- type changes in git

Copy link

@owen-connor owen-connor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finished review

@@ -11,24 +11,24 @@
"cell_type": "markdown",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented on notebook pandas-example.ipynb Cell 9 Line 2

Observe that the indices align accurately regardless of their sequence in the two objects, and the result's indices are organized in ascending order.
As was the case with ``Series``, we can use the associated object's arithmetic method and pass any desired ``fill_value`` to be used in place of missing entries.

Comment

@@ -11,24 +11,24 @@
"cell_type": "markdown",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented on notebook pandas-example.ipynb Cell 3 Line 4

One of the essential pieces of NumPy is the ability to perform quick element-wise operations, both with basic arithmetic (addition, subtraction, multiplication, etc.) and with more sophisticated operations (trigonometric functions, exponential and logarithmic functions, etc.).
Pandas inherits much of this functionality from NumPy, and the ufuncs that we introduced in [Computation on NumPy Arrays: Universal Functions](https://gitnotebooks.com/blog) are key to this.

Pandas includes a couple useful twists, however: for unary operations like negation and trigonometric functions, these ufuncs will *preserve index and column labels* in the output, and for binary operations such as addition and multiplication, Pandas will automatically *align indices* when passing the objects to the ufunc.

my comment!

Copy link

@owen-connor owen-connor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make some changes

@@ -16,7 +16,7 @@
},

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented on notebook sklearn-example.ipynb Cell 5 Line 3

iris['PCA1'] = X_2D[:, 0]
iris['PCA2'] = X_2D[:, 1]
sns.lmplot(x="PCA1", y="PCA2", data=iris, hue='species', fit_reg=False, markers=["o", "s", "D"], palette="Set1");

Comment

@@ -16,7 +16,7 @@
},

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented on notebook sklearn-example.ipynb Cell 6 Line 1

We see that in the two-dimensional representation, the species are fairly well separated, even though the PCA algorithm had no knowledge of the species labels!

comment 2

@@ -11,24 +11,24 @@
"cell_type": "markdown",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented on notebook pandas-example.ipynb Cell 5 Line 1

Any item for which one or the other does not have an entry is marked with ``NaN``, or "Not a Number," which is how Pandas marks missing data (see further discussion of missing data in [Handling Missing Data](03.04-Missing-Values.ipynb)).

comment 3

Copy link
Member Author

@smith-kyle smith-kyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some comments

@@ -16,7 +16,7 @@
},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented on notebook sklearn-example.ipynb Cell 5 From line 1 to 2

iris['PCA1'] = X_2D[:, 0]
iris['PCA2'] = X_2D[:, 1]

Please idk change something here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reply in GitHub

@@ -16,7 +16,7 @@
},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented on notebook sklearn-example.ipynb Cell 7 Line 1

### Unsupervised learning: Dimensionality reduction

Thanks for deleting this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.