Skip to content

Commit 010dd76

Browse files
authored
Merge branch 'master' into nugetprereleasetag
2 parents c23a3f0 + 68981b1 commit 010dd76

File tree

3 files changed

+52
-5
lines changed

3 files changed

+52
-5
lines changed

CONTRIBUTING.md

+6-3
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,12 @@ If you end up not being able to complete the task, please post another comment s
1212
Issues are also welcome, [failing tests](#writing-tests) are even more welcome.
1313

1414
# Contribution Guidelines
15-
- Try to use feature branches rather than developing on master
16-
- Please include tests covering the change
17-
- The docs are now stored in the repository under the `Docs` folder, please include documentation updates with your PR
15+
- Try to use feature branches rather than developing on master.
16+
- Please include tests covering the change.
17+
- The documentation is stored in the repository under the [`docs`](docs) folder.
18+
Have a look at the [documentation readme file](docs/readme.md) for guidance
19+
on how to improve the documentation and please include documentation updates
20+
with your PR.
1821

1922
# How it works
2023
See [how it works](http://gitversion.readthedocs.org/en/latest/more-info/how-it-works/) in GitVersion's documentation

docs/readme.md

+40
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,40 @@
1+
# GitVersion Documentation
2+
3+
This is the directory in which the
4+
[GitVersion documentation hosted on ReadTheDocs](http://gitversion.readthedocs.io/en/latest/)
5+
resides.
6+
7+
## Contributing
8+
9+
Improvements to the documentation is highly welcomed and is as easy
10+
as finding the `.md` file you want to change and editing it directly within
11+
GitHub's web interface.
12+
13+
If you want to do more elaborate changes, we would appreciate if you could test
14+
the documentation locally before submitting a pull request. This involves
15+
[forking](https://guides.github.com/activities/forking/) this repository and
16+
then serving up the documentation locally on your machine, clicking around in
17+
it to ensure that everything works as expected.
18+
19+
## Serving the documentation locally
20+
21+
To serve up the documentation locally, you need to
22+
[install MkDocs](http://www.mkdocs.org/#installation) and then at the root of
23+
the GitVersion project write the following in a command line window:
24+
25+
```shell
26+
mkdocs serve
27+
```
28+
29+
After pressing enter, something similar to the following lines should appear:
30+
31+
```
32+
INFO - Building documentation...
33+
INFO - Cleaning site directory
34+
[I 160810 10:48:18 server:281] Serving on http://127.0.0.1:8000
35+
```
36+
37+
If it says `Serving on http://127.0.0.1:8000`, you should be able to navigate
38+
your favorite browser to `http://127.0.0.1:8000` and browse the documentation
39+
there. If you have any problems with this process, please consult the
40+
[MkDocs documentation](http://www.mkdocs.org/).

src/GitVersionCore.Tests/DocumentationTests.cs

+6-2
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,12 @@ public void DocumentationIndexIsUpToDate()
7878
.ToString()
7979
.Replace("docs/", string.Empty);
8080

81-
Console.WriteLine(fullPath);
82-
Console.WriteLine(relativePath);
81+
// The readme file in the docs directory is not supposed to be deployed to ReadTheDocs;
82+
// it's only there for the convenience of contributors wanting to improve the documentation itself.
83+
if (relativePath == "readme.md")
84+
{
85+
continue;
86+
}
8387

8488
documentationIndexFile.ShouldContain(relativePath, () => string.Format("The file '{0}' is not listed in 'mkdocs.yml'.", relativePath));
8589
}

0 commit comments

Comments
 (0)