MyGet buildNumber message now sent based on LegacySemVerPadded.

Author: maartenba

GitVersionCore/BuildServers/MyGet.cs

@@ -1,6 +1,7 @@
 namespace GitVersion
 {
     using System;
+    using System.Collections.Generic;
 
     public class MyGet : BuildServerBase
     {
@@ -31,35 +32,22 @@ public override void PerformPreProcessingSteps(string gitDirectory)
 
         public override string[] GenerateSetParameterMessage(string name, string value)
         {
-            Environment.SetEnvironmentVariable(string.Format("GitVersion.{0}", name), value, EnvironmentVariableTarget.Process);
-
-            return new[]
+            var messages = new List<string>
             {
-                string.Format("##myget[setParameter name='GitVersion.{0}' value='{1}']", name, EscapeValue(value))
+                string.Format("##myget[setParameter name='GitVersion.{0}' value='{1}']", name, ServiceMessageEscapeHelper.EscapeValue(value))
             };
-        }
-
-        public override string GenerateSetVersionMessage(string versionToUseForBuildNumber)
-        {
-            return string.Format("##myget[buildNumber '{0}']", EscapeValue(versionToUseForBuildNumber));
-        }
 
-        static string EscapeValue(string value)
-        {
-            if (value == null)
+            if (string.Equals(name, "LegacySemVerPadded", StringComparison.InvariantCultureIgnoreCase))
             {
-                return null;
+                messages.Add(string.Format("##myget[buildNumber '{0}']", ServiceMessageEscapeHelper.EscapeValue(value)));
             }
-            // List of escape values from http://confluence.jetbrains.com/display/TCD8/Build+Script+Interaction+with+TeamCity
 
-            value = value.Replace("|", "||");
-            value = value.Replace("'", "|'");
-            value = value.Replace("[", "|[");
-            value = value.Replace("]", "|]");
-            value = value.Replace("\r", "|r");
-            value = value.Replace("\n", "|n");
+            return messages.ToArray();
+        }
 
-            return value;
+        public override string GenerateSetVersionMessage(string versionToUseForBuildNumber)
+        {
+            return null;
         }
     }
 }

GitVersionCore/BuildServers/TeamCity.cs

@@ -30,32 +30,14 @@ public override string[] GenerateSetParameterMessage(string name, string value)
         {
             return new[]
             {
-                string.Format("##teamcity[setParameter name='GitVersion.{0}' value='{1}']", name, EscapeValue(value)),
-                string.Format("##teamcity[setParameter name='system.GitVersion.{0}' value='{1}']", name, EscapeValue(value))
+                string.Format("##teamcity[setParameter name='GitVersion.{0}' value='{1}']", name, ServiceMessageEscapeHelper.EscapeValue(value)),
+                string.Format("##teamcity[setParameter name='system.GitVersion.{0}' value='{1}']", name, ServiceMessageEscapeHelper.EscapeValue(value))
             };
         }
 
         public override string GenerateSetVersionMessage(string versionToUseForBuildNumber)
         {
-            return string.Format("##teamcity[buildNumber '{0}']", EscapeValue(versionToUseForBuildNumber));
-        }
-
-        static string EscapeValue(string value)
-        {
-            if (value == null)
-            {
-                return null;
-            }
-            // List of escape values from http://confluence.jetbrains.com/display/TCD8/Build+Script+Interaction+with+TeamCity
-
-            value = value.Replace("|", "||");
-            value = value.Replace("'", "|'");
-            value = value.Replace("[", "|[");
-            value = value.Replace("]", "|]");
-            value = value.Replace("\r", "|r");
-            value = value.Replace("\n", "|n");
-
-            return value;
+            return string.Format("##teamcity[buildNumber '{0}']", ServiceMessageEscapeHelper.EscapeValue(versionToUseForBuildNumber));
         }
     }
 }

GitVersionCore/Helpers/DeleteHelper.cs

@@ -2,6 +2,26 @@
 {
     using System.IO;
 
+    public static class ServiceMessageEscapeHelper
+    {
+        public static string EscapeValue(string value)
+        {
+            if (value == null)
+            {
+                return null;
+            }
+            // List of escape values from http://confluence.jetbrains.com/display/TCD8/Build+Script+Interaction+with+TeamCity
+
+            value = value.Replace("|", "||");
+            value = value.Replace("'", "|'");
+            value = value.Replace("[", "|[");
+            value = value.Replace("]", "|]");
+            value = value.Replace("\r", "|r");
+            value = value.Replace("\n", "|n");
+
+            return value;
+        }
+    }
     public static class DeleteHelper
     {
         public static void DeleteGitRepository(string directory)

GitVersionTask.Tests/BuildServers/MyGetTests.cs

@@ -10,7 +10,7 @@ public void Develop_branch()
         var authentication = new Authentication();
         var versionBuilder = new MyGet(authentication);
         var message = versionBuilder.GenerateSetVersionMessage("0.0.0-Unstable4");
-        Assert.AreEqual("##myget[buildNumber '0.0.0-Unstable4']", message);
+        Assert.AreEqual(null, message);
     }
 
     [Test]
@@ -22,4 +22,12 @@ public void EscapeValues()
         Assert.AreEqual("##myget[setParameter name='GitVersion.Foo' value='0.8.0-unstable568 Branch:|'develop|' Sha:|'ee69bff1087ebc95c6b43aa2124bd58f5722e0cb|'']", message[0]);
     }
 
+    [Test]
+    public void BuildNumber()
+    {
+        var authentication = new Authentication();
+        var versionBuilder = new MyGet(authentication);
+        var message = versionBuilder.GenerateSetParameterMessage("LegacySemVerPadded", "0.8.0-unstable568");
+        Assert.AreEqual("##myget[buildNumber '0.8.0-unstable568']", message[1]);
+    }
 }