Drop net461?

[pauldotknopf]

It doesn't look like we are using it for any reason, other than the NETDESKTOP define, which doesn't seem needed.

The latest libgit2sharp native binaries are targeting only netstandard, so we wouldn't be able to upgrade.

Can I PR it?

[pauldotknopf]

See #1544

[pauldotknopf]

Hmm, it looks like libgit2sharp was already updated! Not sure how it worked, but I'm gonna roll with it.

With that said though, why is the net461 target needed?

[kll]

It is considered a good practice to do so, mostly for the benefit of downstream packages consuming GitVersion rather than for GitVersion running by itself.

Using .NET Standard 2.0 from .NET Framework has some issues that were addressed in .NET Framework 4.7.2. You can improve the experience for developers that are still on .NET Framework 4.6.1 - 4.7.1 by offering them a binary that is built for .NET Framework 4.6.1.

More detail in this section of the Open-source library guidance.