Fix computed revision cache in v1

gregberge · gregberge · commit a30e71cc6798 · 2025-04-11T12:53:11.000+02:00
diff --git a/packages/cache-tags/src/index.ts b/packages/cache-tags/src/index.ts
@@ -43,6 +43,7 @@ export function getCacheTag(
               tag: 'revision';
               space: string;
               revision: string;
+              tags?: string[];
           }
         /**
          * Immutable data related to a document
@@ -102,8 +103,13 @@ export function getCacheTag(
             return `space:${spec.space}`;
         case 'change-request':
             return `space:${spec.space}:change-request:${spec.changeRequest}`;
-        case 'revision':
-            return `space:${spec.space}:revision:${spec.revision}`;
+        case 'revision': {
+            const key = `space:${spec.space}:revision:${spec.revision}`;
+            if (spec.tags) {
+                return `${key}:${spec.tags.join(':')}`;
+            }
+            return key;
+        }
         case 'document':
             return `space:${spec.space}:document:${spec.document}`;
         case 'computed-document':
diff --git a/packages/gitbook/src/lib/api.ts b/packages/gitbook/src/lib/api.ts
@@ -26,6 +26,7 @@ import {
     type CacheFunctionOptions,
     cache,
     cacheResponse,
+    getResponseCacheTags,
     noCacheFetchOptions,
     parseCacheResponse,
 } from './cache';
@@ -370,6 +371,18 @@ interface GetRevisionOptions {
      * These options don't impact the cache key and it means revisions can be shared between different fetches with different metadata options.
      */
     metadata: boolean;
+
+    /**
+     * Whether to fetch the revision as a computed revision.
+     * @default true
+     */
+    computed?: boolean;
+
+    /**
+     * Additional tags to add to the cache entry.
+     * It's only used for v1, once in v2 we can get rid of it.
+     */
+    tags?: string[];
 }
 
 const getAPIContextId = async () => {
@@ -381,9 +394,14 @@ const getAPIContextId = async () => {
  * Get a revision by its ID.
  */
 export const getRevision = cache({
-    name: 'api.getRevision.v2',
-    tag: (spaceId, revisionId) =>
-        getCacheTag({ tag: 'revision', space: spaceId, revision: revisionId }),
+    name: 'api.getRevision.v3',
+    tag: (spaceId, revisionId, fetchOptions) =>
+        getCacheTag({
+            tag: 'revision',
+            space: spaceId,
+            revision: revisionId,
+            tags: fetchOptions.tags,
+        }),
     tagImmutable: true,
     getKeySuffix: getAPIContextId,
     get: async (
@@ -405,7 +423,13 @@ export const getRevision = cache({
             }
         );
 
-        return cacheResponse(response, fetchOptions.metadata ? cacheTtl_7days : cacheTtl_1day);
+        return cacheResponse(response, {
+            ...(fetchOptions.metadata ? cacheTtl_7days : cacheTtl_1day),
+            data: {
+                revision: response.data,
+                tags: getResponseCacheTags(response),
+            },
+        });
     },
     getKeyArgs: (args) => [args[0], args[1]],
 });
@@ -414,9 +438,14 @@ export const getRevision = cache({
  * Get all the pages in a revision of a space.
  */
 export const getRevisionPages = cache({
-    name: 'api.getRevisionPages.v4',
-    tag: (spaceId, revisionId) =>
-        getCacheTag({ tag: 'revision', space: spaceId, revision: revisionId }),
+    name: 'api.getRevisionPages.v5',
+    tag: (spaceId, revisionId, fetchOptions) =>
+        getCacheTag({
+            tag: 'revision',
+            space: spaceId,
+            revision: revisionId,
+            tags: fetchOptions.tags,
+        }),
     tagImmutable: true,
     getKeySuffix: getAPIContextId,
     get: async (
@@ -440,7 +469,7 @@ export const getRevisionPages = cache({
 
         return cacheResponse(response, {
             ...(fetchOptions.metadata ? cacheTtl_7days : cacheTtl_1day),
-            data: response.data.pages,
+            data: { pages: response.data.pages, tags: getResponseCacheTags(response) },
         });
     },
     getKeyArgs: (args) => [args[0], args[1]],
@@ -632,7 +661,7 @@ export const getRevisionFile = batch<[string, string, string], RevisionFile | nu
             let files: Record<string, RevisionFile> = {};
 
             if (hasRevisionInMemory) {
-                const revision = await getRevision(spaceId, revisionId, { metadata: false });
+                const { revision } = await getRevision(spaceId, revisionId, { metadata: false });
                 files = {};
                 revision.files.forEach((file) => {
                     files[file.id] = file;
@@ -678,7 +707,7 @@ export const getReusableContent = async (
     });
 
     if (hasRevisionInMemory) {
-        const revision = await getRevision(spaceId, revisionId, { metadata: false });
+        const { revision } = await getRevision(spaceId, revisionId, { metadata: false });
         return (
             revision.reusableContents.find(
                 (reusableContent) => reusableContent.id === reusableContentId
diff --git a/packages/gitbook/src/lib/cache/http.ts b/packages/gitbook/src/lib/cache/http.ts
@@ -13,6 +13,14 @@ export const noCacheFetchOptions: Partial<RequestInit> = {
     },
 };
 
+/**
+ * Return the cache tags from the response.
+ */
+export function getResponseCacheTags(response: Response): string[] {
+    const cacheTagHeader = response.headers.get('x-gitbook-cache-tag');
+    return !cacheTagHeader ? [] : cacheTagHeader.split(',');
+}
+
 /**
  * Parse an HTTP response into a cache entry.
  */
@@ -26,8 +34,7 @@ export function parseCacheResponse(response: Response): {
     const cacheControlHeader = response.headers.get('cache-control');
     const cacheControl = cacheControlHeader ? parseCacheControl(cacheControlHeader) : null;
 
-    const cacheTagHeader = response.headers.get('x-gitbook-cache-tag');
-    const tags = !cacheTagHeader ? [] : cacheTagHeader.split(',');
+    const tags = getResponseCacheTags(response);
 
     const entry = {
         ttl: 60 * 60 * 24,
@@ -47,7 +54,7 @@ export function parseCacheResponse(response: Response): {
 export function cacheResponse<Result, DefaultData = Result>(
     response: Response & { data: Result },
     defaultEntry: Partial<CacheResult<DefaultData>> = {}
-): CacheResult<DefaultData extends Result ? Result : DefaultData> {
+): CacheResult<DefaultData extends undefined ? Result : DefaultData> {
     const parsed = parseCacheResponse(response);
 
     return {
diff --git a/packages/gitbook/src/lib/v1.ts b/packages/gitbook/src/lib/v1.ts
@@ -8,6 +8,7 @@ import type { GitBookDataFetcher } from '@v2/lib/data/types';
 import { createImageResizer } from '@v2/lib/images';
 import { createLinker } from '@v2/lib/links';
 
+import { RevisionPageType } from '@gitbook/api';
 import { DataFetcherError, wrapDataFetcherError } from '@v2/lib/data';
 import { headers } from 'next/headers';
 import {
@@ -134,9 +135,25 @@ async function getDataFetcherV1(): Promise<GitBookDataFetcher> {
 
         getRevision(params) {
             return wrapDataFetcherError(async () => {
-                return getRevision(params.spaceId, params.revisionId, {
+                const { revision, tags } = await getRevision(params.spaceId, params.revisionId, {
                     metadata: params.metadata,
+                    computed: false,
                 });
+
+                if (
+                    Object.values(revision.pages).some(
+                        (page) => page.type === RevisionPageType.Computed
+                    )
+                ) {
+                    const { revision } = await getRevision(params.spaceId, params.revisionId, {
+                        metadata: params.metadata,
+                        computed: true,
+                        tags,
+                    });
+                    return revision;
+                }
+
+                return revision;
             });
         },
 
@@ -183,9 +200,22 @@ async function getDataFetcherV1(): Promise<GitBookDataFetcher> {
 
         getRevisionPages(params) {
             return wrapDataFetcherError(async () => {
-                return getRevisionPages(params.spaceId, params.revisionId, {
+                const { pages, tags } = await getRevisionPages(params.spaceId, params.revisionId, {
                     metadata: params.metadata,
+                    computed: false,
                 });
+
+                if (pages.some((page) => page.type === RevisionPageType.Computed)) {
+                    const { pages } = await getRevisionPages(params.spaceId, params.revisionId, {
+                        metadata: params.metadata,
+                        computed: true,
+                        tags,
+                    });
+
+                    return pages;
+                }
+
+                return pages;
             });
         },
 
