Skip to content

Commit 89c0640

Browse files
committed
review: use op for secrets and clean up missed files
1 parent cce8972 commit 89c0640

File tree

7 files changed

+28
-23
lines changed

7 files changed

+28
-23
lines changed

.github/workflows/production.yaml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -57,11 +57,6 @@ jobs:
5757
DISCORD_CLIENT_ID: $ {{ secrets.DISCORD_CLIENT_ID }}
5858
DISCORD_CLIENT_SECRET: $ {{ secrets.DISCORD_CLIENT_SECRET }}
5959
DISCORD_BOT_TOKEN: $ {{ secrets.DISCORD_BOT_TOKEN }}
60-
# Slack
61-
SLACK_CLIENT_ID: ${{ secrets.SLACK_PROD_CLIENT_ID }}
62-
SLACK_CLIENT_SECRET: ${{ secrets.SLACK_PROD_CLIENT_SECRET }}
63-
SLACK_SIGNING_SECRET: ${{ secrets.SLACK_PROD_SIGNING_SECRET }}
64-
SLACK_OPENAI_API_KEY: ${{ secrets.SLACK_OPENAI_API_KEY }}
6560
# Figma
6661
FIGMA_CLIENT_ID: ${{ secrets.FIGMA_PROD_CLIENT_ID }}
6762
FIGMA_CLIENT_SECRET: ${{ secrets.FIGMA_PROD_CLIENT_SECRET }}

.github/workflows/release.yaml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -75,11 +75,6 @@ jobs:
7575
DISCORD_CLIENT_ID: $ {{ secrets.DISCORD_CLIENT_ID }}
7676
DISCORD_CLIENT_SECRET: $ {{ secrets.DISCORD_CLIENT_SECRET }}
7777
DISCORD_BOT_TOKEN: $ {{ secrets.DISCORD_BOT_TOKEN }}
78-
# Slack
79-
SLACK_CLIENT_ID: ${{ secrets.SLACK_STAGING_CLIENT_ID }}
80-
SLACK_CLIENT_SECRET: ${{ secrets.SLACK_STAGING_CLIENT_SECRET }}
81-
SLACK_SIGNING_SECRET: ${{ secrets.SLACK_STAGING_SIGNING_SECRET }}
82-
SLACK_OPENAI_API_KEY: ${{ secrets.SLACK_OPENAI_API_KEY }}
8378
# Figma
8479
FIGMA_CLIENT_ID: ${{ secrets.FIGMA_STAGING_CLIENT_ID }}
8580
FIGMA_CLIENT_SECRET: ${{ secrets.FIGMA_STAGING_CLIENT_SECRET }}

.github/workflows/test.yaml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -91,11 +91,6 @@ jobs:
9191
DISCORD_CLIENT_ID: $ {{ secrets.DISCORD_CLIENT_ID }}
9292
DISCORD_CLIENT_SECRET: $ {{ secrets.DISCORD_CLIENT_SECRET }}
9393
DISCORD_BOT_TOKEN: $ {{ secrets.DISCORD_BOT_TOKEN }}
94-
# Slack
95-
SLACK_CLIENT_ID: ${{ secrets.SLACK_STAGING_CLIENT_ID }}
96-
SLACK_CLIENT_SECRET: ${{ secrets.SLACK_STAGING_CLIENT_SECRET }}
97-
SLACK_SIGNING_SECRET: ${{ secrets.SLACK_STAGING_SIGNING_SECRET }}
98-
SLACK_OPENAI_API_KEY: ${{ secrets.SLACK_OPENAI_API_KEY }}
9994
# Figma
10095
FIGMA_CLIENT_ID: ${{ secrets.FIGMA_STAGING_CLIENT_ID }}
10196
FIGMA_CLIENT_SECRET: ${{ secrets.FIGMA_STAGING_CLIENT_SECRET }}

integrations/slack/.gitignore

Lines changed: 0 additions & 1 deletion
This file was deleted.

integrations/slack/gitbook-manifest.yaml

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,4 +79,30 @@ secrets:
7979
CLIENT_SECRET: ${{ env.SLACK_CLIENT_SECRET }}
8080
SIGNING_SECRET: ${{ env.SLACK_SIGNING_SECRET }}
8181
OPENAI_API_KEY: ${{ env.SLACK_OPENAI_API_KEY }}
82+
envs:
83+
dev-steeve:
84+
organization: idE5kUnGGjoPGcbu3FZJ
85+
secrets:
86+
CLIENT_ID: ${{ "op://gitbook-integrations/slackDevSteeve/CLIENT_ID" }}
87+
CLIENT_SECRET: ${{ "op://gitbook-integrations/slackDevSteeve/CLIENT_SECRET" }}
88+
SIGNING_SECRET: ${{ "op://gitbook-integrations/slackDevSteeve/SIGNING_SECRET" }}
89+
OPENAI_API_KEY: ${{ "op://gitbook-integrations/slackDevSteeve/OPENAI_API_KEY" }}
90+
test:
91+
secrets:
92+
CLIENT_ID: ${{ "op://gitbook-integrations/slackStaging/CLIENT_ID" }}
93+
CLIENT_SECRET: ${{ "op://gitbook-integrations/slackStaging/CLIENT_SECRET" }}
94+
SIGNING_SECRET: ${{ "op://gitbook-integrations/slackStaging/SIGNING_SECRET" }}
95+
OPENAI_API_KEY: ${{ "op://gitbook-integrations/slackStaging/OPENAI_API_KEY" }}
96+
staging:
97+
secrets:
98+
CLIENT_ID: ${{ "op://gitbook-integrations/slackStaging/CLIENT_ID" }}
99+
CLIENT_SECRET: ${{ "op://gitbook-integrations/slackStaging/CLIENT_SECRET" }}
100+
SIGNING_SECRET: ${{ "op://gitbook-integrations/slackStaging/SIGNING_SECRET" }}
101+
OPENAI_API_KEY: ${{ "op://gitbook-integrations/slackStaging/OPENAI_API_KEY" }}
102+
prod:
103+
secrets:
104+
CLIENT_ID: ${{ "op://gitbook-integrations/slackProd/CLIENT_ID" }}
105+
CLIENT_SECRET: ${{ "op://gitbook-integrations/slackProd/CLIENT_SECRET" }}
106+
SIGNING_SECRET: ${{ "op://gitbook-integrations/slackProd/SIGNING_SECRET" }}
107+
OPENAI_API_KEY: ${{ "op://gitbook-integrations/slackProd/OPENAI_API_KEY" }}
82108
target: space

integrations/slack/package.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,7 @@
1919
"scripts": {
2020
"typecheck": "tsc --noEmit",
2121
"check": "gitbook check",
22-
"publish-integrations": "gitbook publish .",
23-
"publish-integrations-staging": "gitbook publish .",
24-
"train-classifier": "bun run scripts/train-classifier.ts --"
22+
"publish-integrations": "gitbook publish . --env prod",
23+
"publish-integrations-staging": "gitbook publish . --env staging"
2524
}
2625
}

turbo.json

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,6 @@
1717
"DISCORD_CLIENT_ID",
1818
"DISCORD_CLIENT_SECRET",
1919
"DISCORD_BOT_TOKEN",
20-
"SLACK_CLIENT_ID",
21-
"SLACK_CLIENT_SECRET",
22-
"SLACK_SIGNING_SECRET",
23-
"SLACK_OPENAI_API_KEY",
2420
"FIGMA_CLIENT_ID",
2521
"FIGMA_CLIENT_SECRET",
2622
"MAILCHIMP_CLIENT_ID",

0 commit comments

Comments
 (0)