Skip to content

Commit 102d38a

Browse files
committed
remove a TODO that turned out to be unnecessary.
After all, stopping the merge when there is any conflict is highly relevant.
1 parent 3fb989b commit 102d38a

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

gix-merge/src/tree/mod.rs

+2-5
Original file line numberDiff line numberDiff line change
@@ -236,11 +236,8 @@ pub struct Options {
236236
/// The context to use when invoking merge-drivers.
237237
pub blob_merge_command_ctx: gix_command::Context,
238238
/// If `Some(what-is-unresolved)`, the first unresolved conflict will cause the entire merge to stop.
239-
/// This is useful to see if there is any conflict, without performing the whole operation.
240-
// TODO: Maybe remove this if the cost of figuring out conflicts is so low - after all, the data structures
241-
// and initial diff is the expensive thing right now, which are always done upfront.
242-
// However, this could change once we know do everything during the traversal, which probably doesn't work
243-
// without caching stuff and is too complicated to actually do.
239+
/// This is useful to see if there is any conflict, without performing the whole operation, something
240+
/// that can be very relevant during merges that would cause a lot of blob-diffs.
244241
pub fail_on_conflict: Option<UnresolvedConflict>,
245242
/// This value also affects the size of merge-conflict markers, to allow differentiating
246243
/// merge conflicts on each level, for any value greater than 0, with values `N` causing `N*2`

0 commit comments

Comments
 (0)