Merge pull request #1854 from GitoxideLabs/montly-report

montly report

Author: Byron

Cargo.toml

@@ -325,6 +325,7 @@ bin-dir = "gitoxide-max-pure-v{ version }-{ target }/{ bin }{ binary-ext }"
 pedantic = { level = "warn", priority = -1 }
 #
 # Reviewed and allowed lints
+needless_continue = "allow"
 enum_glob_use = "allow"  # x97
 missing_errors_doc = "allow"  # x1792
 missing_panics_doc = "allow"  # x447

deny.toml

@@ -8,7 +8,7 @@
 # More documentation for the advisories section can be found here:
 # https://embarkstudios.github.io/cargo-deny/checks/advisories/cfg.html
 [advisories]
-ignore = []
+ignore = ['RUSTSEC-2025-0007']
 
 
 

etc/reports/25-02.md

@@ -0,0 +1,32 @@
+Like the previous month was the first in 2025 with plenty of news to share, this month is a first as well: I seem to have nothing to write about.
+
+Sure, there were a couple of smaller API improvements, but nothing that would inspire me.
+So what did I do all this time? Probably this is the moment where there really is no other way but to talk about GitButler, something I avoided last month just because it doesn't seem to belong into the `gitoxide` newsletter.
+
+## GitButler
+
+[GitButler](https://gitbutler.com) is what I have been working on intensely for the last two months effectively, in a push to help it to unfold its true potential. Thus far it was mostly powered by `git2`, with `gitoxide` sprinkled in there, but the next iteration will be the inverse with `git2` only being used where `gitoxide` is lacking a feature. That way, along with massive architectural changes, it will be able to cope with large repositories and be more compatible with various Git features, too.
+
+I cannot wait to see all this work to finally come to fruition, and of course, to also see myself being pulled to a user interface that truly elevates my workflow and the workflow of other devs just like me who thus far preferred to stay on the command-line.
+
+## Community
+
+### Faster `gix blame`
+
+Christoph Rüßler kept working and managed to greatly improve the `gix blame` performance while increasing its conformance to Git at the same time. This means that now, depending on the sample, `gix blame` *can* be a bit faster than Git, but it typically is still up to 30% slower when commitgraph caches are used. Overall though, the performance is nothing to sneeze at, and it competes quite well except for in pathological cases.
+Admittedly, I am quite blown away by the performance and have a feeling that last time I checked, I didn't use the latest version of the `gix` binary.
+It's worth noting that rename-tracking still isn't support, but I also see no reason why it shouldn't be eventually, a feature that would make `gix blame` so much more useful in practice.
+
+### `gix blame` with experimental cache
+
+A pretty [slim PR](https://github.com/GitoxideLabs/gitoxide/pull/1852) shows how to use a special cache to greatly speedup blames, from ~300ms down to just ~4ms, a massive 75x speedup that would be very useful for editors and IDEs, or forges, I am sure!
+Of course, one first has to build such cache, and probably do so per file, but I am sure there are plenty of use-cases for it when it's driven by dev tooling.
+
+### Gix in Cargo
+
+With `gix status` now available I am planning to integrate it as soon as possible! That didn't happen yet, but… it will, the stack to work off before I can start this is pretty high though so it's unlikely to happen anytime soon.
+
+Cheers
+Sebastian
+
+PS: The latest timesheets can be found [here (2025)](https://github.com/Byron/byron/blob/main/timesheets/2025.csv). 

gitoxide-core/src/hours/mod.rs

@@ -180,7 +180,7 @@ where
                         break;
                     }
                     Err(err) => return Err(err.into()),
-                };
+                }
             }
             if let Some(tx) = tx_tree_id {
                 tx.send(chunk).ok();

gitoxide-core/src/index/information.rs

@@ -92,16 +92,16 @@ mod serde_only {
                     });
                     if f.link().is_some() {
                         names.push("link");
-                    };
+                    }
                     if f.resolve_undo().is_some() {
                         names.push("resolve-undo (REUC)");
-                    };
+                    }
                     if f.untracked().is_some() {
                         names.push("untracked (UNTR)");
-                    };
+                    }
                     if f.fs_monitor().is_some() {
                         names.push("fs-monitor (FSMN)");
-                    };
+                    }
                     if f.had_offset_table() {
                         names.push("offset-table (IEOT)");
                     }

gitoxide-core/src/lib.rs

@@ -86,7 +86,7 @@ pub use discover::discover;
 pub fn env(mut out: impl std::io::Write, format: OutputFormat) -> anyhow::Result<()> {
     if format != OutputFormat::Human {
         bail!("JSON output isn't supported");
-    };
+    }
 
     let width = 15;
     writeln!(

gitoxide-core/src/pack/explode.rs

@@ -161,7 +161,7 @@ pub fn pack_or_pack_index(
         )
     })?;
 
-    if !object_path.as_ref().map_or(true, |p| p.as_ref().is_dir()) {
+    if !object_path.as_ref().is_none_or(|p| p.as_ref().is_dir()) {
         return Err(anyhow!(
             "The object directory at '{}' is inaccessible",
             object_path

gitoxide-core/src/pack/index.rs

@@ -114,7 +114,7 @@ pub fn from_pack(
         OutputFormat::Human => drop(human_output(out, res)),
         #[cfg(feature = "serde")]
         OutputFormat::Json => serde_json::to_writer_pretty(out, &res)?,
-    };
+    }
     Ok(())
 }
 

gitoxide-core/src/pack/receive.rs

@@ -306,6 +306,6 @@ fn receive_pack_blocking(
         OutputFormat::Json => {
             serde_json::to_writer_pretty(&mut out, &JsonOutcome::from_outcome_and_refs(outcome, refs))?;
         }
-    };
+    }
     Ok(())
 }

gitoxide-core/src/pack/verify.rs

@@ -177,7 +177,7 @@ where
                         #[cfg(feature = "serde")]
                         Some(OutputFormat::Json) => serde_json::to_writer_pretty(out, &multi_index.index_names().iter().zip(res.pack_traverse_statistics).collect::<Vec<_>>())?,
                         _ => {}
-                    };
+                    }
                     return Ok(())
                 },
                 _ => return Err(anyhow!(
@@ -195,7 +195,7 @@ where
             #[cfg(feature = "serde")]
             Some(OutputFormat::Json) => serde_json::to_writer_pretty(out, stats)?,
             _ => {}
-        };
+        }
     }
     Ok(())
 }