Skip to content

Commit 2e7517e

Browse files
committed
Comment gix_transport::client::blocking_io::ssh::connect
To note that if the `-G` check ever also uses the username, then that has to be checked to ensure it is safe.
1 parent f56ad39 commit 2e7517e

File tree

1 file changed

+2
-0
lines changed
  • gix-transport/src/client/blocking_io/ssh

1 file changed

+2
-0
lines changed

gix-transport/src/client/blocking_io/ssh/mod.rs

+2
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,8 @@ pub fn connect(
118118
.stdin(Stdio::null())
119119
.with_shell()
120120
.arg("-G")
121+
// Username affects the stdout from `ssh -G` but may not affect the status. But if
122+
// we end up needing it, it can be added here, with a user_argument_safe() check.
121123
.arg(url.host_argument_safe().ok_or_else(|| Error::AmbiguousHostName {
122124
host: url.host().expect("set in ssh urls").into(),
123125
})?),

0 commit comments

Comments
 (0)