Skip to content

Commit 3c1be39

Browse files
committed
Make test-fixtures-windows required for PR auto-merge
Since #1663, the `test-fixtures-windows` CI job checks actual failures against a list of specific tests that are known to fail on Windows when `GIX_TEST_IGNORE_ARCHIVES=1`. It is therefore capable of providing useful information about new failures, or newly passing tests that should be removed from the list, if the job ever does fail. The job also seems not to fail. This is to say that while #1358 is not fixed, the `test-fixtures-windows` job has a very low rate of failure and, if it does fail, something new and interesting would be happening such that we would want to know about it and probably not immediately merge a PR that caused it without checking how and why that happened. This adds `test-fixtures-windows` to the list of jobs that are dependencies of a required check for branch protection based PR auto-merge.
1 parent 97f85f7 commit 3c1be39

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/ci.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -387,7 +387,6 @@ jobs:
387387
env:
388388
# List all jobs that are intended NOT to block PR auto-merge here.
389389
EXPECTED_NONBLOCKING_JOBS: |-
390-
test-fixtures-windows
391390
cargo-deny-advisories
392391
wasm
393392
tests-pass
@@ -424,6 +423,7 @@ jobs:
424423
- test
425424
- test-journey
426425
- test-fast
426+
- test-fixtures-windows
427427
- test-32bit
428428
- lint
429429
- cargo-deny

0 commit comments

Comments
 (0)