Skip to content

Commit 77a3a1b

Browse files
committed
fix: Use less ambiguous "kB" for SI kilobyte
`gix free pack verify --statistics` formerly used "KB" for kilobytes (i.e., SI decimal kilobytes, units of 1000 bytes). This was somewhat ambiguous because it is occasionally also used for kibibytes (i.e., IEC binary kibibytes, units of 1024 bytes). Kilobytes and kibibytes can be more precisely distinguished by using kB for kilobytes (since "k" is the SI prefix for "kilo") and KiB for kibibytes (since decimal kilobytes are never written KiB). This adapts `gitoxide-core` to changes in `bytesize` and, in so doing, allows the SI unit symbol "kB" to be used. Fixes #1947
1 parent 2fc48a1 commit 77a3a1b

File tree

3 files changed

+16
-16
lines changed

3 files changed

+16
-16
lines changed

Diff for: gitoxide-core/src/pack/verify.rs

+4-4
Original file line numberDiff line numberDiff line change
@@ -236,10 +236,10 @@ fn print_statistics(out: &mut impl io::Write, stats: &index::traverse::Statistic
236236
#[rustfmt::skip]
237237
writeln!(
238238
out, "\t{:<width$}: {}\n\t{:<width$}: {}\n\t{:<width$}: {}\n\t{:<width$}: {}",
239-
"compressed entries size", ByteSize(stats.total_compressed_entries_size),
240-
"decompressed entries size", ByteSize(stats.total_decompressed_entries_size),
241-
"total object size", ByteSize(stats.total_object_size),
242-
"pack size", ByteSize(stats.pack_size),
239+
"compressed entries size", ByteSize(stats.total_compressed_entries_size).display().si(),
240+
"decompressed entries size", ByteSize(stats.total_decompressed_entries_size).display().si(),
241+
"total object size", ByteSize(stats.total_object_size).display().si(),
242+
"pack size", ByteSize(stats.pack_size).display().si(),
243243
width = width
244244
)?;
245245
#[rustfmt::skip]

Diff for: tests/snapshots/plumbing/no-repo/pack/verify/index-with-statistics-success

+4-4
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@ averages
1515
decompressed object size [B]: 9621;
1616

1717
compression
18-
compressed entries size : 51.8 KB
19-
decompressed entries size : 103.7 KB
20-
total object size : 288.7 KB
21-
pack size : 51.9 KB
18+
compressed entries size : 51.8 kB
19+
decompressed entries size : 103.7 kB
20+
total object size : 288.7 kB
21+
pack size : 51.9 kB
2222

2323
num trees : 15
2424
num blobs : 5

Diff for: tests/snapshots/plumbing/no-repo/pack/verify/multi-index/index-with-statistics-success

+8-8
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,10 @@ averages
1616
decompressed object size [B]: 9621;
1717

1818
compression
19-
compressed entries size : 51.8 KB
20-
decompressed entries size : 103.7 KB
21-
total object size : 288.7 KB
22-
pack size : 51.9 KB
19+
compressed entries size : 51.8 kB
20+
decompressed entries size : 103.7 kB
21+
total object size : 288.7 kB
22+
pack size : 51.9 kB
2323

2424
num trees : 15
2525
num blobs : 5
@@ -43,10 +43,10 @@ averages
4343
decompressed object size [B]: 2093;
4444

4545
compression
46-
compressed entries size : 48.9 KB
47-
decompressed entries size : 132.8 KB
48-
total object size : 140.2 KB
49-
pack size : 49.1 KB
46+
compressed entries size : 48.9 kB
47+
decompressed entries size : 132.8 kB
48+
total object size : 140.2 kB
49+
pack size : 49.1 kB
5050

5151
num trees : 2
5252
num blobs : 63

0 commit comments

Comments
 (0)