Skip to content

Commit 8729858

Browse files
committed
Run check-mode recipe on CI via ci-test recipe
This adds the `check-mode` recipe to the `test` recipe and, more significantly because of its effect on CI, to the `ci-test` recipe. This causes the CI `test` job to run the `check-mode` recipe (and thus `it check-mode` through it). While the separate `check-mode` CI job was useful for developing the tool, it imposes extra work, due to the need to build dependencies that are, to a substantial extent, shared with those already present (and cached) for the `test` job. Now that it is run via the `test` CI job, the separate `check-mode` CI job is removed.
1 parent 2305099 commit 8729858

File tree

2 files changed

+2
-13
lines changed

2 files changed

+2
-13
lines changed

.github/workflows/ci.yml

-11
Original file line numberDiff line numberDiff line change
@@ -359,16 +359,6 @@ jobs:
359359
- name: gix-pack with all features (including wasm)
360360
run: cd gix-pack && cargo build --all-features --target "$TARGET"
361361

362-
check-mode:
363-
runs-on: ubuntu-latest
364-
365-
steps:
366-
- uses: actions/checkout@v4
367-
- uses: dtolnay/rust-toolchain@stable
368-
- uses: extractions/setup-just@v2
369-
- name: Find scripts with mode/shebang mismatch
370-
run: just check-mode
371-
372362
check-packetline:
373363
strategy:
374364
fail-fast: false
@@ -451,7 +441,6 @@ jobs:
451441
- test-32bit-cross
452442
- lint
453443
- cargo-deny
454-
- check-mode
455444
- check-packetline
456445
- check-blocking
457446

justfile

+2-2
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,10 @@ alias c := check
1010
alias nt := nextest
1111

1212
# run all tests, clippy, including journey tests, try building docs
13-
test: clippy check doc unit-tests journey-tests-pure journey-tests-small journey-tests-async journey-tests
13+
test: clippy check doc unit-tests journey-tests-pure journey-tests-small journey-tests-async journey-tests check-mode
1414

1515
# run all tests, without clippy, and try building docs
16-
ci-test: check doc unit-tests
16+
ci-test: check doc unit-tests check-mode
1717

1818
# run all journey tests - should be run in a fresh clone or after `cargo clean`
1919
ci-journey-tests: journey-tests-pure journey-tests-small journey-tests-async journey-tests

0 commit comments

Comments
 (0)