From 7b3104d20f33e5e8c8375a49431d9232894c89c6 Mon Sep 17 00:00:00 2001 From: Eliah Kagan Date: Tue, 7 May 2024 00:57:46 +0000 Subject: [PATCH] Change to GIX_TEST_IGNORE_ARCHIVES on CI and docs to match code The test suite checks for `GIX_TEST_IGNORE_ARCHIVES` and not for `GITOXIDE_TEST_IGNORE_ARCHIVES`. But the main test workflow `ci.yml`, as well as in the instructions in `DEVELOPMENT.md`, had given `GITOXIDE_TEST_IGNORE_ARCHIVES`. This fixes that. --- .github/workflows/ci.yml | 2 +- DEVELOPMENT.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 81caaa7a583..65c9945169f 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -57,7 +57,7 @@ jobs: - name: test env: CI: true - GITOXIDE_TEST_IGNORE_ARCHIVES: 1 + GIX_TEST_IGNORE_ARCHIVES: 1 run: just ci-test test-fast: diff --git a/DEVELOPMENT.md b/DEVELOPMENT.md index b9d3ee59593..24b5fb3b768 100644 --- a/DEVELOPMENT.md +++ b/DEVELOPMENT.md @@ -262,7 +262,7 @@ get an overview. ## Reviewing PRs -- be sure to clone locally and run tests with `GITOXIDE_TEST_IGNORE_ARCHIVES=1` to assure new fixture scripts (if there are any) are validated +- be sure to clone locally and run tests with `GIX_TEST_IGNORE_ARCHIVES=1` to assure new fixture scripts (if there are any) are validated on _MacOS_ and _Windows_. Note that linux doesn't need to be tested that way as CI on linux ignores them by merit of not checking them out via `gix-lfs`.