Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GIVpower on a newly GIVbacks eligible project isn't working properly #4980

Open
laurenluz opened this issue Jan 28, 2025 · 3 comments
Open
Labels
bug Something isn't working

Comments

@laurenluz
Copy link
Member

It might be that the projects are GIVbacks eligible but not "vouched"... but anyway GIVbacks eligible should always also be "vouched" by default

Image

Image

Image

https://giveth.io/project/dctrl-clubhouse-events-space

@WhyldWanderer @divine-comedian

@github-project-automation github-project-automation bot moved this to New Issues in All-Devs Jan 28, 2025
@laurenluz laurenluz added the bug Something isn't working label Jan 28, 2025
@laurenluz laurenluz moved this from New Issues to Product Backlog in All-Devs Jan 28, 2025
@divine-comedian
Copy link
Contributor

divine-comedian commented Jan 28, 2025

Very strange - I think I reported this in #4900 and @LatifatAbdullahi I think you also tested it in Giveth/impact-graph#1848

This happens because the admin panel action is not also giving the project the status of verified=true so the givpower feature is behaving as if the project isn't eligible for givpower on that specific table (but it still can be boosted)

@LatifatAbdullahi could you check on production that:

when an admin approves a projects givbacks eligible form after it's been submitted we should make sure that for the given project:

givbacksEligible=true
verified=true

this might have been fixed in the recent release and we should double check on production it is behaving correctly.

@LatifatAbdullahi
Copy link

@divine-comedian

This behaves correctly on Production.

On Production;
Givback Eligibility form: Submitted

Action: Approve Eligibility form

Result:
givbacksEligible=true
verified=true (by default)

Giveth.-.Google.Chrome.2025-01-29.09-13-24.mp4

@divine-comedian
Copy link
Contributor

Thanks @LatifatAbdullahi I also tested boosting the project and checking if the error reported appears for the project you showed in your testing - can confirm this error does not appear.

I am asking if the project review team might be doing something different when they approve givbacks elig. forms that could be causing this issue to persist.

otherwise we might have fixed this in the release we made on monday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Product Backlog
Development

No branches or pull requests

3 participants