Skip to content

Commit 1c600d5

Browse files
committed
revert ORM logger from interface to glog.Logger
1 parent 9bc3b44 commit 1c600d5

File tree

5 files changed

+12
-40
lines changed

5 files changed

+12
-40
lines changed

database/gdb/gdb.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -152,8 +152,8 @@ type DB interface {
152152
GetGroup() string // See Core.GetGroup.
153153
SetDryRun(enabled bool) // See Core.SetDryRun.
154154
GetDryRun() bool // See Core.GetDryRun.
155-
SetLogger(logger Logger) // See Core.SetLogger.
156-
GetLogger() Logger // See Core.GetLogger.
155+
SetLogger(logger *glog.Logger) // See Core.SetLogger.
156+
GetLogger() *glog.Logger // See Core.GetLogger.
157157
GetConfig() *ConfigNode // See Core.GetConfig.
158158
SetMaxIdleConnCount(n int) // See Core.SetMaxIdleConnCount.
159159
SetMaxOpenConnCount(n int) // See Core.SetMaxOpenConnCount.
@@ -179,7 +179,7 @@ type Core struct {
179179
debug *gtype.Bool // Enable debug mode for the database, which can be changed in runtime.
180180
cache *gcache.Cache // Cache manager, SQL result cache only.
181181
schema *gtype.String // Custom schema for this object.
182-
logger Logger // Logger for logging functionality.
182+
logger *glog.Logger // Logger for logging functionality.
183183
config *ConfigNode // Current config node.
184184
}
185185

@@ -347,7 +347,7 @@ func New(group ...string) (db DB, err error) {
347347
debug: gtype.NewBool(),
348348
cache: gcache.New(),
349349
schema: gtype.NewString(),
350-
logger: LoggerImp{glog.New()},
350+
logger: glog.New(),
351351
config: node,
352352
}
353353
if v, ok := driverMap[node.Type]; ok {

database/gdb/gdb_core_config.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ package gdb
88

99
import (
1010
"fmt"
11+
"github.com/gogf/gf/os/glog"
1112
"sync"
1213
"time"
1314

@@ -133,12 +134,12 @@ func IsConfigured() bool {
133134
}
134135

135136
// SetLogger sets the logger for orm.
136-
func (c *Core) SetLogger(logger Logger) {
137+
func (c *Core) SetLogger(logger *glog.Logger) {
137138
c.logger = logger
138139
}
139140

140-
// GetLogger returns the logger of the orm.
141-
func (c *Core) GetLogger() Logger {
141+
// GetLogger returns the (logger) of the orm.
142+
func (c *Core) GetLogger() *glog.Logger {
142143
return c.logger
143144
}
144145

database/gdb/gdb_core_logger.go

Lines changed: 0 additions & 27 deletions
This file was deleted.

database/gdb/gdb_z_mysql_ctx_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ func Test_Ctx(t *testing.T) {
3030
}
3131

3232
func Test_Ctx_Query(t *testing.T) {
33-
db.GetLogger().(gdb.LoggerImp).SetCtxKeys("SpanId", "TraceId")
33+
db.GetLogger().SetCtxKeys("SpanId", "TraceId")
3434
gtest.C(t, func(t *gtest.T) {
3535
db.SetDebug(true)
3636
defer db.SetDebug(false)
@@ -48,7 +48,7 @@ func Test_Ctx_Query(t *testing.T) {
4848
func Test_Ctx_Model(t *testing.T) {
4949
table := createInitTable()
5050
defer dropTable(table)
51-
db.GetLogger().(gdb.LoggerImp).SetCtxKeys("SpanId", "TraceId")
51+
db.GetLogger().SetCtxKeys("SpanId", "TraceId")
5252
gtest.C(t, func(t *gtest.T) {
5353
db.SetDebug(true)
5454
defer db.SetDebug(false)

frame/gins/gins_database.go

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -132,10 +132,8 @@ func Database(name ...string) gdb.DB {
132132
loggerConfigMap = Config().GetMap(configNodeKey)
133133
}
134134
if len(loggerConfigMap) > 0 {
135-
if logger, ok := db.GetLogger().(gdb.LoggerImp); ok {
136-
if err := logger.SetConfigWithMap(loggerConfigMap); err != nil {
137-
panic(err)
138-
}
135+
if err := db.GetLogger().SetConfigWithMap(loggerConfigMap); err != nil {
136+
panic(err)
139137
}
140138
}
141139
}

0 commit comments

Comments
 (0)