[test] Remove the test/unittests/ folder completely.

Move the last bits from the old tree structure and don't use the
`test/unittests/` folder from now on.

Fixed: b:325903709, b:323795674
Doc: http://go/chrome-devtools:move-unit-tests-design
Change-Id: I47d727348d115d07f6b04b818359940c4361109a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5332214
Commit-Queue: Benedikt Meurer <[email protected]>
Auto-Submit: Benedikt Meurer <[email protected]>
Reviewed-by: Simon Zünd <[email protected]>

Author: bmeurer

front_end/BUILD.gn

@@ -93,3 +93,146 @@ group("embedder-scripts") {
     grd_files = get_target_outputs(":embedder-scripts-gen")
   }
 }
+
+group("unittests") {
+  deps = [
+    "Images:optimize_images",
+    "core/common:unittests",
+    "core/dom_extension:unittests",
+    "core/host:unittests",
+    "core/i18n:unittests",
+    "core/i18n/locales",
+    "core/platform:unittests",
+    "core/protocol_client:unittests",
+    "core/root:unittests",
+    "core/sdk:unittests",
+    "entrypoints/formatter_worker:unittests",
+    "entrypoints/heap_snapshot_worker:unittests",
+    "entrypoints/inspector_main:unittests",
+    "entrypoints/main:unittests",
+    "entrypoints/wasmparser_worker:unittests",
+    "models/autofill_manager:unittests",
+    "models/bindings:unittests",
+    "models/breakpoints:unittests",
+    "models/cpu_profile:unittests",
+    "models/emulation:unittests",
+    "models/extensions:unittests",
+    "models/formatter:unittests",
+    "models/har:unittests",
+    "models/heap_snapshot_model:unittests",
+    "models/issues_manager:unittests",
+    "models/javascript_metadata:unittests",
+    "models/logs:unittests",
+    "models/persistence:unittests",
+    "models/source_map_scopes:unittests",
+    "models/text_utils:unittests",
+    "models/timeline_model:unittests",
+    "models/trace:unittests",
+    "models/trace/extras:unittests",
+    "models/trace/handlers:unittests",
+    "models/trace/helpers:unittests",
+    "models/trace/insights:unittests",
+    "models/trace/root-causes:unittests",
+    "models/trace/types:unittests",
+    "models/workspace:unittests",
+    "models/workspace_diff:unittests",
+    "panels/accessibility:unittests",
+    "panels/animation:unittests",
+    "panels/application:unittests",
+    "panels/application/components:unittests",
+    "panels/application/fixtures",
+    "panels/application/preloading/components:unittests",
+    "panels/autofill:unittests",
+    "panels/browser_debugger:unittests",
+    "panels/changes:unittests",
+    "panels/console:unittests",
+    "panels/console_counters:unittests",
+    "panels/coverage:unittests",
+    "panels/css_overview:unittests",
+    "panels/developer_resources:unittests",
+    "panels/elements:unittests",
+    "panels/emulation:unittests",
+    "panels/explain:unittests",
+    "panels/issues:unittests",
+    "panels/layer_viewer:unittests",
+    "panels/layers:unittests",
+    "panels/lighthouse:unittests",
+    "panels/linear_memory_inspector:unittests",
+    "panels/linear_memory_inspector/components:unittests",
+    "panels/media:unittests",
+    "panels/mobile_throttling:unittests",
+    "panels/network:unittests",
+    "panels/network/components:unittests",
+    "panels/performance_monitor:unittests",
+    "panels/profiler:unittests",
+    "panels/protocol_monitor:unittests",
+    "panels/protocol_monitor/components:unittests",
+    "panels/recorder:unittests",
+    "panels/recorder/components:unittests",
+    "panels/recorder/converters:unittests",
+    "panels/recorder/injected/selectors:unittests",
+    "panels/recorder/models:unittests",
+    "panels/recorder/testing",
+    "panels/recorder/util:unittests",
+    "panels/screencast:unittests",
+    "panels/search:unittests",
+    "panels/security:unittests",
+    "panels/settings/components:unittests",
+    "panels/settings/emulation/components:unittests",
+    "panels/settings/emulation/utils:unittests",
+    "panels/snippets:unittests",
+    "panels/sources:unittests",
+    "panels/sources/components:unittests",
+    "panels/timeline:unittests",
+    "panels/timeline/components:unittests",
+    "panels/timeline/fixtures/traces",
+    "panels/timeline/track_appenders:unittests",
+    "panels/utils:unittests",
+    "panels/web_audio:unittests",
+    "panels/webauthn:unittests",
+    "services/trace_bounds:unittests",
+    "testing",
+    "third_party/chromium/client-variations:unittests",
+    "third_party/i18n:unittests",
+    "ui/components/adorners:unittests",
+    "ui/components/buttons:unittests",
+    "ui/components/chrome_link:unittests",
+    "ui/components/code_highlighter:unittests",
+    "ui/components/data_grid:unittests",
+    "ui/components/dialogs:unittests",
+    "ui/components/diff_view:unittests",
+    "ui/components/expandable_list:unittests",
+    "ui/components/helpers:unittests",
+    "ui/components/highlighting:unittests",
+    "ui/components/icon_button:unittests",
+    "ui/components/issue_counter:unittests",
+    "ui/components/linkifier:unittests",
+    "ui/components/markdown_view:unittests",
+    "ui/components/menus:unittests",
+    "ui/components/node_text:unittests",
+    "ui/components/panel_feedback:unittests",
+    "ui/components/render_coordinator:unittests",
+    "ui/components/report_view:unittests",
+    "ui/components/request_link_icon:unittests",
+    "ui/components/settings:unittests",
+    "ui/components/split_view:unittests",
+    "ui/components/survey_link:unittests",
+    "ui/components/text_editor:unittests",
+    "ui/components/text_prompt:unittests",
+    "ui/components/tree_outline:unittests",
+    "ui/components/two_states_counter:unittests",
+    "ui/legacy:copy_stylesheets_for_server",
+    "ui/legacy:unittests",
+    "ui/legacy/components/color_picker:unittests",
+    "ui/legacy/components/inline_editor:unittests",
+    "ui/legacy/components/object_ui:unittests",
+    "ui/legacy/components/perf_ui:unittests",
+    "ui/legacy/components/quick_open:unittests",
+    "ui/legacy/components/source_frame:unittests",
+    "ui/legacy/components/utils:unittests",
+    "ui/legacy/theme_support:unittests",
+    "ui/legacy/utils:unittests",
+    "ui/lit-html:unittests",
+    "ui/visual_logging:unittests",
+  ]
+}

scripts/test/run_auto_unittests.py

@@ -79,7 +79,7 @@ def main():
                         help='Save coverage files to swarming output.')
     args = parser.parse_args(sys.argv[1:])
 
-    efficiently_recompile.recompile(args.target, 'test/unittests')
+    efficiently_recompile.recompile(args.target, 'test:unittests')
     run_unittests.run_unit_tests_on_ninja_build_target(
         args.target, args.no_text_coverage, args.no_html_coverage,
         args.coverage, args.expanded_reporting, args.chrome_binary, args.cwd,

scripts/test/run_unittests.py

@@ -32,7 +32,7 @@ def run_tests(chrome_binary, target, no_text_coverage, no_html_coverage,
               coverage, expanded_reporting, cwd, log_level, mocha_fgrep,
               shuffle, karma_args):
     karmaconfig_path = os.path.join(cwd, 'out', target, 'gen', 'test',
-                                    'unittests', 'karma.conf.js')
+                                    'karma.conf.js')
 
     if not os.path.exists(karmaconfig_path):
         log_message('Unable to find Karma config at ' + karmaconfig_path,

test/BUILD.gn

@@ -7,14 +7,26 @@ import("../scripts/build/ninja/copy.gni")
 group("test") {
   deps = [
     ":config",
+    ":unittests",
     "e2e",
     "interactions",
     "perf",
     "shared",
-    "unittests",
+  ]
+}
+
+group("unittests") {
+  deps = [
+    ":config",
+    "../front_end:unittests",
+    "../inspector_overlay:unittests",
+    "shared",
   ]
 }
 
 copy_to_gen("config") {
-  sources = [ "base-mocharc.js" ]
+  sources = [
+    "base-mocharc.js",
+    "karma.conf.js",
+  ]
 }

test/unittests/karma.conf.js renamed to test/karma.conf.js

@@ -9,8 +9,8 @@ const path = require('path');
 const glob = require('glob');
 const fs = require('fs');
 const rimraf = require('rimraf');
-const debugCheck = require('./debug-check.js');
-const ResultsDb = require('../shared/resultsdb.js');
+const {debugCheck} = require('./shared/debug-check.js');
+const ResultsDb = require('./shared/resultsdb.js');
 
 const USER_DEFINED_COVERAGE_FOLDERS = process.env['COVERAGE_FOLDERS'];
 
@@ -28,7 +28,7 @@ const COVERAGE_OUTPUT_DIRECTORY = 'karma-coverage';
 // Initially set this to true if the user has enabled it, but we then check
 // because coverage only gives accurate results in debug builds, so if this
 // build is not a debug build, we disable coverage and log a warning.
-let coverageEnabled = COVERAGE_ENABLED_BY_USER;
+const coverageEnabled = COVERAGE_ENABLED_BY_USER;
 if (coverageEnabled) {
   /* Clear out the old coverage directory so you can't accidentally open old,
    * out of date coverage output.
@@ -38,19 +38,21 @@ if (coverageEnabled) {
     rimraf.sync(fullPathToDirectory);
   }
 
-  debugCheck(__dirname).then(isDebug => {
-    if (!isDebug) {
-      const warning = `The unit tests appear to be running against a non-debug build and
+  if (!debugCheck(__dirname)) {
+    const warning = `The unit tests appear to be running against a non-debug build and
 your coverage report will be inaccurate and incomplete due to the bundle being rolled-up.
 
 Therefore, coverage has been disabled.
 
 In order to get a complete coverage report please run against a
 target with is_debug = true in the args.gn file.`;
-      console.warn(colors.magenta(warning));
-      coverageEnabled = false;
-    }
-  });
+    console.warn(colors.magenta(warning));
+    // TODO(bmeurer): Apparently the debug-check.js was broken before and didn't work,
+    // at least on the Release bots. Which means that we never disabled coverage for
+    // those Release builds. We might want to look into updating the infra to also not
+    // expect the coverage to be there.
+    // coverageEnabled = false;
+  }
 }
 // true by default
 const TEXT_COVERAGE_ENABLED = coverageEnabled && !process.env['NO_TEXT_COVERAGE'];
@@ -59,7 +61,7 @@ const HTML_COVERAGE_ENABLED = coverageEnabled && !process.env['NO_HTML_COVERAGE'
 // false by default
 const SHUFFLE = process.env['SHUFFLE'];
 
-const GEN_DIRECTORY = path.join(__dirname, '..', '..');
+const GEN_DIRECTORY = path.join(__dirname, '..');
 const ROOT_DIRECTORY = path.join(GEN_DIRECTORY, '..', '..', '..');
 const singleRun = !(DEBUG_ENABLED || REPEAT_ENABLED);
 

test/shared/BUILD.gn

@@ -8,6 +8,7 @@ node_ts_library("shared") {
   sources = [
     "async-scope.ts",
     "config.ts",
+    "debug-check.ts",
     "helper.ts",
     "mocha-extensions.ts",
     "mocha-resultsdb-reporter.ts",
@@ -17,5 +18,6 @@ node_ts_library("shared") {
     "snapshots.ts",
     "text-color.ts",
   ]
+
   deps = [ "../conductor:implementation" ]
 }

test/unittests/debug-check.js renamed to test/shared/debug-check.ts

@@ -2,21 +2,21 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-const fs = require('fs').promises;
-const path = require('path');
+import {readFileSync} from 'fs';
+import {join} from 'path';
+
 const isDebug = /^\s*is_debug\s*=\s*(.*)/;
 
 /**
  * Tests the args.gn file to ensure that the is_debug flag is set to true.
  * We don't cover every case here, for example where is_debug is redefined
  * in the gn.args several times. Instead we use the first declaration of
  * is_debug's value.
- * @param {string} dirName
  */
-async function debugCheck(dirName) {
-  const argsFile = path.join(dirName, '..', '..', '..', 'args.gn');
+export function debugCheck(dirName: string): boolean {
+  const argsFile = join(dirName, '..', '..', 'args.gn');
   try {
-    const fileDetails = await fs.readFile(argsFile, {encoding: 'utf8'});
+    const fileDetails = readFileSync(argsFile, {encoding: 'utf8'});
     for (const line of fileDetails.split('\n')) {
       if (!isDebug.test(line)) {
         continue;
@@ -40,9 +40,7 @@ async function debugCheck(dirName) {
     // By default, a DevTools build is always a debug build,
     // unless `is_debug` is explicitly set to false
     return true;
-  } catch (error) {
+  } catch {
     return false;
   }
 }
-
-module.exports = debugCheck;